This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7841

nodemap: add a optional `nodemap_add_full` method on indexes
ClosedPublic

Authored by marmoute on Jan 13 2020, 10:07 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG7f4f7ef3133e: nodemap: add a optional `nodemap_add_full` method on indexes
Summary

This method can be used to obtains persistent data for a full nodemap. The end
goal is for some index implementation to managed the nodemap serialization them
selves (eg: the rust implementation)

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

marmoute created this revision.Jan 13 2020, 10:07 AM
marmoute updated this revision to Diff 19295.Jan 15 2020, 9:54 AM
marmoute edited the summary of this revision. (Show Details)Jan 31 2020, 10:28 AM
marmoute updated this revision to Diff 19757.
marmoute updated this revision to Diff 19786.Jan 31 2020, 5:58 PM
marmoute updated this revision to Diff 19830.Feb 2 2020, 3:17 AM

small doc update on .#s[1]

marmoute updated this revision to Diff 19889.Feb 4 2020, 7:24 PM

rebase to latest default

marmoute added a commit: rHG7f4f7ef3133e: nodemap: add a optional `nodemap_add_full` method on indexes.Feb 10 2020, 8:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG7f4f7ef3133e: nodemap: add a optional `nodemap_add_full` method on indexes (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19889

mercurial/pure/parsers.py

class PersistentNodeMapIndexObject(IndexObject): class PersistentNodeMapIndexObject(IndexObject):
"""a Debug oriented class to test persistent nodemap """a Debug oriented class to test persistent nodemap
We need a simple python object to test API and higher level behavior. See We need a simple python object to test API and higher level behavior. See
the Rust implementation for more serious usage. This should be used only the Rust implementation for more serious usage. This should be used only
through the dedicated `devel.persistent-nodemap` config. through the dedicated `devel.persistent-nodemap` config.
""" """
def nodemap_data_all(self):
"""Return bytes containing a full serialization of a nodemap
The nodemap should be valid for the full set of revisions in the
index."""
return nodemaputil.persistent_data(self)
class InlinedIndexObject(BaseIndexObject): class InlinedIndexObject(BaseIndexObject):
def __init__(self, data, inline=0): def __init__(self, data, inline=0):
self._data = data self._data = data
self._lgt = self._inline_scan(None) self._lgt = self._inline_scan(None)
self._inline_scan(self._lgt) self._inline_scan(self._lgt)
self._extra = [] self._extra = []

mercurial/revlogutils/nodemap.py

import os import os
import re import re
import struct import struct
from .. import ( from .. import (
error, error,
node as nodemod, node as nodemod,
pycompat, util,
) )
class NodeMap(dict): class NodeMap(dict):
def __missing__(self, x): def __missing__(self, x):
raise error.RevlogError(b'unknown node: %s' % x) raise error.RevlogError(b'unknown node: %s' % x)
""" """
if getattr(revlog, 'filteredrevs', ()): if getattr(revlog, 'filteredrevs', ()):
raise error.ProgrammingError( raise error.ProgrammingError(
"cannot persist nodemap of a filtered changelog" "cannot persist nodemap of a filtered changelog"
) )
if revlog.nodemap_file is None: if revlog.nodemap_file is None:
msg = "calling persist nodemap on a revlog without the feature enableb" msg = "calling persist nodemap on a revlog without the feature enableb"
raise error.ProgrammingError(msg) raise error.ProgrammingError(msg)
if util.safehasattr(revlog.index, "nodemap_data_all"):
data = revlog.index.nodemap_data_all()
else:
data = persistent_data(revlog.index) data = persistent_data(revlog.index)
uid = _make_uid() uid = _make_uid()
datafile = _rawdata_filepath(revlog, uid) datafile = _rawdata_filepath(revlog, uid)
olds = _other_rawdata_filepath(revlog, uid) olds = _other_rawdata_filepath(revlog, uid)
if olds: if olds:
realvfs = getattr(revlog, '_realopener', revlog.opener) realvfs = getattr(revlog, '_realopener', revlog.opener)
def cleanup(tr): def cleanup(tr):
for oldfile in olds: for oldfile in olds: