| hg-reviewers |
Having the iteration inside the serialization function does not help
readability. Now that we have a Block object, let us move that code there.
| Lint Skipped |
| Unit Tests Skipped |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/revlogutils/nodemap.py (5 lines) |
| Commit | Parents | Author | Summary | Date |
|---|---|---|---|---|
| d9dcd8992389 | 657afb7fa14b | Pierre-Yves David | Jan 15 2020, 9:48 AM |
| Status | Author | Revision | |
|---|---|---|---|
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute |
| return int(hex_digit, 16) | return int(hex_digit, 16) | ||||
| class Block(dict): | class Block(dict): | ||||
| """represent a block of the Trie | """represent a block of the Trie | ||||
| contains up to 16 entry indexed from 0 to 15""" | contains up to 16 entry indexed from 0 to 15""" | ||||
| pass | def __iter__(self): | ||||
| return iter(self.get(i) for i in range(16)) | |||||
| def _build_trie(index): | def _build_trie(index): | ||||
| """build a nodemap trie | """build a nodemap trie | ||||
| The nodemap stores revision number for each unique prefix. | The nodemap stores revision number for each unique prefix. | ||||
| Each block is a dictionary with keys in `[0, 15]`. Values are either | Each block is a dictionary with keys in `[0, 15]`. Values are either | ||||
| def _persist_block(block_node, block_map): | def _persist_block(block_node, block_map): | ||||
| """produce persistent binary data for a single block | """produce persistent binary data for a single block | ||||
| Children block are assumed to be already persisted and present in | Children block are assumed to be already persisted and present in | ||||
| block_map. | block_map. | ||||
| """ | """ | ||||
| data = tuple(_to_value(block_node.get(i), block_map) for i in range(16)) | data = tuple(_to_value(v, block_map) for v in block_node) | ||||
| return S_BLOCK.pack(*data) | return S_BLOCK.pack(*data) | ||||
| def _to_value(item, block_map): | def _to_value(item, block_map): | ||||
| """persist any value as an integer""" | """persist any value as an integer""" | ||||
| if item is None: | if item is None: | ||||
| return NO_ENTRY | return NO_ENTRY | ||||
| elif isinstance(item, dict): | elif isinstance(item, dict): | ||||
| return block_map[id(item)] | return block_map[id(item)] | ||||
| else: | else: | ||||
| return _transform_rev(item) | return _transform_rev(item) | ||||