nodemap: all check that revision and nodes match in the nodemap
ClosedPublic

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	19183		Jan 13 2020, 10:07 AM	★	★
Diff 2	19300		Jan 15 2020, 9:55 AM	★	★
Diff 3	19762		Jan 31 2020, 10:28 AM	★	★
Diff 4	19791		Jan 31 2020, 5:59 PM	★	★
Diff 5	19835		Feb 2 2020, 3:18 AM	★	★
Diff 6	19894		Feb 4 2020, 7:24 PM	★	★
Diff 7	20114	rHGd58206b70199059036361ba7f4a10f7ac95808a5	Jan 15 2020, 9:49 AM	★	★

Commit	Parents	Author	Summary	Date
2c10bfa92177	b45bfbf81ec8	Pierre-Yves David		Jan 15 2020, 9:49 AM

Status	Author	Revision
Closed	marmoute	D7894 nodemap: introduce an option to use mmap to read the nodemap mapping
Closed	marmoute	D7893 nodemap: update the index with the newly written data (when appropriate)
Closed	marmoute	D7892 nodemap: never read more than the expected data amount
Closed	marmoute	D7891 nodemap: write new data from the expected current data length
Closed	marmoute	D7890 nodemap: double check the source docket when doing incremental update
Closed	marmoute	D7889 nodemap: track the total and unused amount of data in the rawdata file
Closed	marmoute	D7888 nodemap: track the maximum revision tracked in the nodemap
Closed	marmoute	D7887 nodemap: add a flag to dump the details of the docket
Closed	marmoute	D7886 nodemap: introduce append-only incremental update of the persisten data
Closed	marmoute	D7885 nodemap: keep track of the docket for loaded data
Closed	marmoute	D7884 nodemap: introduce an explicit class/object for the docket
Closed	marmoute	D7883 nodemap: keep track of the ondisk id of nodemap blocks
Closed	marmoute	D7847 nodemap: provide the on disk data to indexes who support it
Closed	marmoute	D7846 nodemap: all check that revision and nodes match in the nodemap
Closed	marmoute	D7845 nodemap: add basic checking of the on disk nodemap content
Closed	marmoute	D7844 nodemap: code to parse the persistent binary nodemap data
Closed	marmoute	D7843 nodemap: move the iteratio inside the Block object
Closed	marmoute	D7842 nodemap: use an explicit "Block" object in the reference implementation
Closed	marmoute	D7841 nodemap: add a optional `nodemap_add_full` method on indexes
Closed	marmoute	D7840 nodemap: add a (python) index class for persistent nodemap testing
Closed	marmoute	D7839 nodemap: delete older raw data file when creating a new ones
Closed	marmoute	D7838 nodemap: use an intermediate "docket" file to carry small metadata
Closed	marmoute	D7837 nodemap: only use persistent nodemap for non-inlined revlog
Closed	marmoute	D7836 nodemap: add a function to read the data from disk
Closed	marmoute	D7835 nodemap: write nodemap data on disk
Closed	marmoute	D7834 nodemap: have some python code writing a nodemap in persistent binary form

Diff 19300

mercurial/revlogutils/nodemap.py

	ui.status((b"revision in nodemap: %d\n") % len(all_revs))			ui.status((b"revision in nodemap: %d\n") % len(all_revs))
	for r in range(len(index)):			for r in range(len(index)):
	if r not in all_revs:			if r not in all_revs:
	msg = b" revision missing from nodemap: %d\n" % r			msg = b" revision missing from nodemap: %d\n" % r
	ui.write_err(msg)			ui.write_err(msg)
	ret = 1			ret = 1
	else:			else:
	all_revs.remove(r)			all_revs.remove(r)
				nm_rev = _find_node(root, nodemod.hex(index[r][7]))
				if nm_rev is None:
				msg = b" revision node does not match any entries: %d\n" % r
				ui.write_err(msg)
				ret = 1
				elif nm_rev != r:
				msg = (
				b" revision node does not match the expected revision: "
				b"%d != %d\n" % (r, nm_rev)
				)
				ui.write_err(msg)
				ret = 1

	if all_revs:			if all_revs:
	for r in sorted(all_revs):			for r in sorted(all_revs):
	msg = b" extra revision in nodemap: %d\n" % r			msg = b" extra revision in nodemap: %d\n" % r
	ui.write_err(msg)			ui.write_err(msg)
	ret = 1			ret = 1
	return ret			return ret


	def _all_revisions(root):			def _all_revisions(root):
	"""return all revisions stored in a Trie"""			"""return all revisions stored in a Trie"""
	for block in _walk_trie(root):			for block in _walk_trie(root):
	for v in block:			for v in block:
	if v is None or isinstance(v, Block):			if v is None or isinstance(v, Block):
	continue			continue
	yield v			yield v


				def _find_node(block, node):
				"""find the revision associated with a given node"""
				entry = block.get(_to_int(node[0]))
				if isinstance(entry, dict):
				return _find_node(entry, node[1:])
				return entry

This is an archive of the discontinued Mercurial Phabricator instance.

nodemap: all check that revision and nodes match in the nodemapClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19300

mercurial/revlogutils/nodemap.py

nodemap: all check that revision and nodes match in the nodemap
ClosedPublic

Revision Contents
Changeset List