Page MenuHomePhabricator

phases: make phasecache._phasesets immutable
ClosedPublic

Authored by rdamazio on Jan 13 2020, 10:18 PM.

Details

Summary

Previously, some code paths would mutate the cache itself, which
could give weird results if multiple revsets got evaluated through
that path.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rdamazio created this revision.Jan 13 2020, 10:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.