This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7883

nodemap: keep track of the ondisk id of nodemap blocks
ClosedPublic

Authored by marmoute on Jan 15 2020, 9:55 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf0862ee1a31e: nodemap: keep track of the ondisk id of nodemap blocks
Summary

If we are to incrementally update the files, we need to keep some details about
the data we read.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

marmoute created this revision.Jan 15 2020, 9:55 AM
marmoute updated this revision to Diff 19764.Jan 31 2020, 10:29 AM
marmoute updated this revision to Diff 19792.Jan 31 2020, 5:59 PM
marmoute updated this revision to Diff 19836.Feb 2 2020, 3:18 AM

small doc update on .#s[1]

marmoute updated this revision to Diff 19895.Feb 4 2020, 7:25 PM

rebase to latest default

marmoute added a commit: rHGf0862ee1a31e: nodemap: keep track of the ondisk id of nodemap blocks.Feb 10 2020, 8:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGf0862ee1a31e: nodemap: keep track of the ondisk id of nodemap blocks (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/nodemap.py (9 lines)

Diff 19836

mercurial/revlogutils/nodemap.py

return int(hex_digit, 16) return int(hex_digit, 16)
class Block(dict): class Block(dict):
"""represent a block of the Trie """represent a block of the Trie
contains up to 16 entry indexed from 0 to 15""" contains up to 16 entry indexed from 0 to 15"""
def __init__(self):
super(Block, self).__init__()
# If this block exist on disk, here is its ID
self.ondisk_id = None
def __iter__(self): def __iter__(self):
return iter(self.get(i) for i in range(16)) return iter(self.get(i) for i in range(16))
def _build_trie(index): def _build_trie(index):
"""build a nodemap trie """build a nodemap trie
The nodemap stores revision number for each unique prefix. The nodemap stores revision number for each unique prefix.
block = _parse_block(block_map, data[i : i + S_BLOCK.size]) block = _parse_block(block_map, data[i : i + S_BLOCK.size])
return block return block
def _parse_block(block_map, block_data): def _parse_block(block_map, block_data):
"""Parse the persisted version of an individual block """Parse the persisted version of an individual block
""" """
block = Block() block = Block()
ondisk_id = len(block_map) block.ondisk_id = len(block_map)
block_map[ondisk_id] = block block_map[block.ondisk_id] = block
values = S_BLOCK.unpack(block_data) values = S_BLOCK.unpack(block_data)
for idx, v in enumerate(values): for idx, v in enumerate(values):
if v == NO_ENTRY: if v == NO_ENTRY:
continue continue
elif v >= 0: elif v >= 0:
block[idx] = block_map[v] block[idx] = block_map[v]
else: else:
block[idx] = _transform_rev(v) block[idx] = _transform_rev(v)