Page MenuHomePhabricator

sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008
ClosedPublic

Authored by mharbison72 on Jan 15 2020, 11:34 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 15 2020, 11:34 PM
mharbison72 added inline comments.Jan 16 2020, 9:33 AM
mercurial/thirdparty/sha1dc/lib/ubc_check.h
35

I see that ef36156eac9f uses typedef unsigned __int32 uint32_t if somebody wants to fix in flight.

yuja added a subscriber: yuja.Jan 16 2020, 10:08 AM

#ifndef SHA1DC_NO_STANDARD_INCLUDES
+#if !defined(_MSC_VER) || _MSC_VER >= 1600
#include <stdint.h>
+#else
+/* prior to Visual Studio 2010 */
+typedef unsigned int uint32_t;

unsigned __int32 for consistency.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.