( )⚙ D7992 clean: delete obsolete unlinking of .hg/graftstate

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7992

clean: delete obsolete unlinking of .hg/graftstate
ClosedPublic

Authored by martinvonz on Jan 24 2020, 6:31 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG3245cdea2c63: clean: delete obsolete unlinking of .hg/graftstate
Summary

The responsibility for clearing it is now in
cmdutil.clearunfinished(), so we shouldn't have to unlink it in
hg.clean().

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Jan 24 2020, 6:31 PM
martinvonz updated this revision to Diff 19735.Jan 31 2020, 1:30 AM
martinvonz added a commit: rHG3245cdea2c63: clean: delete obsolete unlinking of .hg/graftstate.Feb 6 2020, 5:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG3245cdea2c63: clean: delete obsolete unlinking of .hg/graftstate (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hg.py (1 line)

Diff 19580

mercurial/hg.py

# naming conflict in clone() # naming conflict in clone()
_update = update _update = update
def clean(repo, node, show_stats=True, quietempty=False): def clean(repo, node, show_stats=True, quietempty=False):
"""forcibly switch the working directory to node, clobbering changes""" """forcibly switch the working directory to node, clobbering changes"""
stats = updaterepo(repo, node, True) stats = updaterepo(repo, node, True)
assert stats.unresolvedcount == 0 assert stats.unresolvedcount == 0
repo.vfs.unlinkpath(b'graftstate', ignoremissing=True)
if show_stats: if show_stats:
_showstats(repo, stats, quietempty) _showstats(repo, stats, quietempty)
# naming conflict in updatetotally() # naming conflict in updatetotally()
_clean = clean _clean = clean
_VALID_UPDATECHECKS = { _VALID_UPDATECHECKS = {