This is an archive of the discontinued Mercurial Phabricator instance.

Differential D814

tweakdefaults: fix test to avoid unnecessary double execution
ClosedPublic

Authored by singhsrb on Sep 25 2017, 3:44 PM.
Tags
None
Subscribers
ryanmce, quark

Details

Reviewers
quark
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGX8b8ac5ed1dce: tweakdefaults: fix test to avoid unnecessary double execution
Summary

D802 added two test cases in the test but the test cases are only used
for a very little portion of the test and therefore, result in needless double
execution for most of the test. Therefore, this commit removes the test cases
and instead, handles the different cases by passing the corresponding config
option.

Test Plan

ran test-tweakdefaults.t

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Sep 25 2017, 3:44 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2017, 3:44 PM
singhsrb edited the test plan for this revision. (Show Details)Sep 25 2017, 3:45 PM
quark accepted this revision.Sep 25 2017, 6:43 PM
quark added a subscriber: quark.

Looks good. Thanks!

This revision is now accepted and ready to land.Sep 25 2017, 6:43 PM
ryanmce added a subscriber: ryanmce.Sep 26 2017, 3:36 AM

I've refactored this code in another commit. See D812. Let's sync up about the best way forward here.

ryanmce requested changes to this revision.Sep 26 2017, 3:36 AM
This revision now requires changes to proceed.Sep 26 2017, 3:36 AM
Closed by commit rFBHGX8b8ac5ed1dce: tweakdefaults: fix test to avoid unnecessary double execution (authored by singhsrb). · Explain WhySep 26 2017, 5:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-tweakdefaults.t (26 lines)

Diff 2102

tests/test-tweakdefaults.t

#testcases develwarn.true develwarn.false
$ . "$TESTDIR/histedit-helpers.sh" $ . "$TESTDIR/histedit-helpers.sh"
$ cat >> $HGRCPATH << EOF $ cat >> $HGRCPATH << EOF
> [extensions] > [extensions]
> tweakdefaults=$TESTDIR/../hgext3rd/tweakdefaults.py > tweakdefaults=$TESTDIR/../hgext3rd/tweakdefaults.py
> fbamend=$TESTDIR/../hgext3rd/fbamend > fbamend=$TESTDIR/../hgext3rd/fbamend
> rebase= > rebase=
> histedit= > histedit=
> [experimental] > [experimental]
> updatecheck=noconflict > updatecheck=noconflict
> EOF > EOF
#if develwarn.false
$ cat >> $HGRCPATH << EOF
> [tweakdefaults]
> develwarn = False
> EOF
#endif
Setup repo Setup repo
$ hg init repo $ hg init repo
$ cd repo $ cd repo
$ touch a $ touch a
$ hg commit -Aqm a $ hg commit -Aqm a
$ mkdir dir $ mkdir dir
$ touch dir/b $ touch dir/b
o 2 o 2
| |
o 1 master o 1 master
| |
o 0 o 0
Test that developer warning is shown whenever ':' is used implicitly or explicitly Test that developer warning is shown whenever ':' is used implicitly or explicitly
#if develwarn.true
$ hg log -G -T '{rev} {bookmarks}' -r '0:2' $ hg log -G -T '{rev} {bookmarks}' -r '0:2'
devel-warn: use of ':' is deprecated devel-warn: use of ':' is deprecated
at: *tweakdefaults.py:* (_analyzewrap) (glob) at: *tweakdefaults.py:* (_analyzewrap) (glob)
o 2 o 2
| |
o 1 master o 1 master
| |
o 0 o 0
#else
$ hg log -G -T '{rev} {bookmarks}' -r '0:2' $ hg log -G -T '{rev} {bookmarks}' -r '0:2' --config tweakdefaults.develwarn=False
o 2 o 2
| |
o 1 master o 1 master
| |
o 0 o 0
#endif
#if develwarn.true
$ hg log -G -T '{rev} {bookmarks}' -r ':2' $ hg log -G -T '{rev} {bookmarks}' -r ':2'
devel-warn: use of ':' is deprecated devel-warn: use of ':' is deprecated
at: *tweakdefaults.py:* (_analyzewrap) (glob) at: *tweakdefaults.py:* (_analyzewrap) (glob)
o 2 o 2
| |
o 1 master o 1 master
| |
o 0 o 0
#else
$ hg log -G -T '{rev} {bookmarks}' -r ':2' $ hg log -G -T '{rev} {bookmarks}' -r ':2' --config tweakdefaults.develwarn=False
o 2 o 2
| |
o 1 master o 1 master
| |
o 0 o 0
#endif
#if develwarn.true
$ hg log -G -T '{rev} {bookmarks}' -r '0:' $ hg log -G -T '{rev} {bookmarks}' -r '0:'
devel-warn: use of ':' is deprecated devel-warn: use of ':' is deprecated
at: *tweakdefaults.py:* (_analyzewrap) (glob) at: *tweakdefaults.py:* (_analyzewrap) (glob)
o 2 o 2
| |
o 1 master o 1 master
| |
o 0 o 0
#else
$ hg log -G -T '{rev} {bookmarks}' -r '0:' $ hg log -G -T '{rev} {bookmarks}' -r '0:' --config tweakdefaults.develwarn=False
o 2 o 2
| |
o 1 master o 1 master
| |
o 0 o 0
#endif
In this testcase warning should not be shown In this testcase warning should not be shown
$ hg log -G -T '{rev} {bookmarks}' -r ':' $ hg log -G -T '{rev} {bookmarks}' -r ':'
o 2 o 2
| |
o 1 master o 1 master
| |
o 0 o 0