Page MenuHomePhabricator

darwin: add another preemptive gui() call when using chg
ClosedPublic

Authored by spectral on Feb 20 2020, 9:05 PM.

Details

Summary

Changeset a89381e04c58 added this gui() call before background forks, and
Google's extensions do background forks on essentially every invocation for
logging purposes. The crash is reliably (though not 100%) reproducible without
this change when running HGPLAIN=1 chg status in one of our repos. With this
fix, I haven't been able to trigger the crash anymore.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Feb 20 2020, 9:05 PM
marmoute accepted this revision.Feb 21 2020, 3:49 AM
marmoute added a subscriber: marmoute.

I would be nice to have test but I assume this is hard. The description seems clear so I trusting Kyle on this one.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.