This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8176

transaction: clarify the logic around pre-finalize/post-finalize
ClosedPublic

Authored by marmoute on Feb 28 2020, 7:05 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf6798c1a80fa: transaction: clarify the logic around pre-finalize/post-finalize
Summary

I am taking a bit more verbose route, but I find it easier to follow for people
who (re)discover the code.

(This is a gratuitous cleanup I did while looking at something else.)

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Feb 28 2020, 7:05 AM
marmoute added a commit: rHGf6798c1a80fa: transaction: clarify the logic around pre-finalize/post-finalize.Feb 28 2020, 2:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGf6798c1a80fa: transaction: clarify the logic around pre-finalize/post-finalize (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/transaction.py (16 lines)

Diff 20370

mercurial/transaction.py

def removefilegenerator(self, genid): def removefilegenerator(self, genid):
"""reverse of addfilegenerator, remove a file generator function""" """reverse of addfilegenerator, remove a file generator function"""
if genid in self._filegenerators: if genid in self._filegenerators:
del self._filegenerators[genid] del self._filegenerators[genid]
def _generatefiles(self, suffix=b'', group=GEN_GROUP_ALL): def _generatefiles(self, suffix=b'', group=GEN_GROUP_ALL):
# write files registered for generation # write files registered for generation
any = False any = False
if group == GEN_GROUP_ALL:
skip_post = skip_pre = False
else:
skip_pre = group == GEN_GROUP_POST_FINALIZE
skip_post = group == GEN_GROUP_PRE_FINALIZE
for id, entry in sorted(pycompat.iteritems(self._filegenerators)): for id, entry in sorted(pycompat.iteritems(self._filegenerators)):
any = True any = True
order, filenames, genfunc, location = entry order, filenames, genfunc, location = entry
# for generation at closing, check if it's before or after finalize # for generation at closing, check if it's before or after finalize
postfinalize = group == GEN_GROUP_POST_FINALIZE is_post = id in postfinalizegenerators
if ( if skip_post and is_post:
group != GEN_GROUP_ALL continue
and (id in postfinalizegenerators) != postfinalize elif skip_pre and not is_post:
):
continue continue
vfs = self._vfsmap[location] vfs = self._vfsmap[location]
files = [] files = []
try: try:
for name in filenames: for name in filenames:
name += suffix name += suffix
if suffix: if suffix: