This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8278

rust-core: add missing `Debug` traits
ClosedPublic

Authored by Alphare on Mar 12 2020, 7:43 PM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHGece43c79333e: rust-core: add missing `Debug` traits
Summary

Turns out you need them when trying to use hg-core as a library. Who knew.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Mar 12 2020, 7:43 PM
marmoute accepted this revision.Mar 12 2020, 9:06 PM
Alphare added a commit: rHGece43c79333e: rust-core: add missing `Debug` traits.Mar 16 2020, 11:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGece43c79333e: rust-core: add missing `Debug` traits (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20807

rust/hg-core/src/dirstate/status.rs

) { ) {
results.par_extend( results.par_extend(
stat_dmap_entries(dmap, root_dir, options) stat_dmap_entries(dmap, root_dir, options)
.flatten() .flatten()
.map(|(filename, dispatch)| (Cow::Borrowed(filename), dispatch)), .map(|(filename, dispatch)| (Cow::Borrowed(filename), dispatch)),
); );
} }
#[derive(Debug)]
pub struct DirstateStatus<'a> { pub struct DirstateStatus<'a> {
pub modified: Vec<Cow<'a, HgPath>>, pub modified: Vec<Cow<'a, HgPath>>,
pub added: Vec<Cow<'a, HgPath>>, pub added: Vec<Cow<'a, HgPath>>,
pub removed: Vec<Cow<'a, HgPath>>, pub removed: Vec<Cow<'a, HgPath>>,
pub deleted: Vec<Cow<'a, HgPath>>, pub deleted: Vec<Cow<'a, HgPath>>,
pub clean: Vec<Cow<'a, HgPath>>, pub clean: Vec<Cow<'a, HgPath>>,
pub ignored: Vec<Cow<'a, HgPath>>, pub ignored: Vec<Cow<'a, HgPath>>,
pub unknown: Vec<Cow<'a, HgPath>>, pub unknown: Vec<Cow<'a, HgPath>>,
clean, clean,
ignored, ignored,
unknown, unknown,
bad, bad,
}, },
) )
} }
#[derive(Debug)]
pub enum StatusError { pub enum StatusError {
IO(std::io::Error), IO(std::io::Error),
Path(HgPathError), Path(HgPathError),
Pattern(PatternError), Pattern(PatternError),
} }
pub type StatusResult<T> = Result<T, StatusError>; pub type StatusResult<T> = Result<T, StatusError>;

rust/hg-core/src/lib.rs

"expected a value, found none".to_string() "expected a value, found none".to_string()
} }
DirstateMapError::EmptyPath => "Overflow in dirstate.".to_string(), DirstateMapError::EmptyPath => "Overflow in dirstate.".to_string(),
DirstateMapError::InvalidPath(e) => e.to_string(), DirstateMapError::InvalidPath(e) => e.to_string(),
} }
} }
} }
#[derive(Debug)]
pub enum DirstateError { pub enum DirstateError {
Parse(DirstateParseError), Parse(DirstateParseError),
Pack(DirstatePackError), Pack(DirstatePackError),
Map(DirstateMapError), Map(DirstateMapError),
IO(std::io::Error), IO(std::io::Error),
} }
impl From<DirstateParseError> for DirstateError { impl From<DirstateParseError> for DirstateError {