This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8297

vfs: fix typo in comment (remove extra "l")
ClosedPublic

Authored by spectral on Mar 17 2020, 4:16 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG77d48738b8e0: vfs: fix typo in comment (remove extra "l")

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Mar 17 2020, 4:16 PM
spectral added a commit: rHG77d48738b8e0: vfs: fix typo in comment (remove extra "l").Mar 17 2020, 5:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG77d48738b8e0: vfs: fix typo in comment (remove extra "l") (authored by spectral). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/vfs.py (2 lines)

Diff 20814

mercurial/vfs.py

are writing thousands of files, the performance benefits of are writing thousands of files, the performance benefits of
asynchronously closing files is not realized. asynchronously closing files is not realized.
2. Files are opened exactly once for the ``backgroundclosing`` 2. Files are opened exactly once for the ``backgroundclosing``
active duration and are therefore free of race conditions between active duration and are therefore free of race conditions between
closing a file on a background thread and reopening it. (If the closing a file on a background thread and reopening it. (If the
file were opened multiple times, there could be unflushed data file were opened multiple times, there could be unflushed data
because the original file handle hasn't been flushed/closed yet.) because the original file handle hasn't been flushed/closed yet.)
``checkambig`` argument is passed to atomictemplfile (valid ``checkambig`` argument is passed to atomictempfile (valid
only for writing), and is useful only if target file is only for writing), and is useful only if target file is
guarded by any lock (e.g. repo.lock or repo.wlock). guarded by any lock (e.g. repo.lock or repo.wlock).
To avoid file stat ambiguity forcibly, checkambig=True involves To avoid file stat ambiguity forcibly, checkambig=True involves
copying ``path`` file opened in "append" mode (e.g. for copying ``path`` file opened in "append" mode (e.g. for
truncation), if it is owned by another. Therefore, use truncation), if it is owned by another. Therefore, use
combination of append mode and checkambig=True only in limited combination of append mode and checkambig=True only in limited
cases (see also issue5418 and issue5584 for detail). cases (see also issue5418 and issue5584 for detail).