| hg-reviewers |
| No Linters Available |
| No Unit Test Coverage |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/vfs.py (2 lines) |
| Commit | Parents | Author | Summary | Date |
|---|---|---|---|---|
| ccb84df82fe5 | adb93aa98c78 | Kyle Lippincott | Jul 22 2019, 12:58 PM |
| are writing thousands of files, the performance benefits of | are writing thousands of files, the performance benefits of | ||||
| asynchronously closing files is not realized. | asynchronously closing files is not realized. | ||||
| 2. Files are opened exactly once for the ``backgroundclosing`` | 2. Files are opened exactly once for the ``backgroundclosing`` | ||||
| active duration and are therefore free of race conditions between | active duration and are therefore free of race conditions between | ||||
| closing a file on a background thread and reopening it. (If the | closing a file on a background thread and reopening it. (If the | ||||
| file were opened multiple times, there could be unflushed data | file were opened multiple times, there could be unflushed data | ||||
| because the original file handle hasn't been flushed/closed yet.) | because the original file handle hasn't been flushed/closed yet.) | ||||
| ``checkambig`` argument is passed to atomictemplfile (valid | ``checkambig`` argument is passed to atomictempfile (valid | ||||
| only for writing), and is useful only if target file is | only for writing), and is useful only if target file is | ||||
| guarded by any lock (e.g. repo.lock or repo.wlock). | guarded by any lock (e.g. repo.lock or repo.wlock). | ||||
| To avoid file stat ambiguity forcibly, checkambig=True involves | To avoid file stat ambiguity forcibly, checkambig=True involves | ||||
| copying ``path`` file opened in "append" mode (e.g. for | copying ``path`` file opened in "append" mode (e.g. for | ||||
| truncation), if it is owned by another. Therefore, use | truncation), if it is owned by another. Therefore, use | ||||
| combination of append mode and checkambig=True only in limited | combination of append mode and checkambig=True only in limited | ||||
| cases (see also issue5418 and issue5584 for detail). | cases (see also issue5418 and issue5584 for detail). | ||||