This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8439

make: drop the `-c` arg to `install` in the documentation makefile
ClosedPublic

Authored by mharbison72 on Apr 15 2020, 10:28 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGeb9026a84e83: make: drop the `-c` arg to `install` in the documentation makefile
Summary

This arg caused gmake install on OpenIndiana 2019.10 (illumos) fail with:

install: The -c, -f, -n options each require a directory following!
install: The -c, -f, -n options each require a directory following!
install: The -c, -f, -n options each require a directory following!
gmake[1]: *** [Makefile:41: install] Error 2
gmake[1]: Leaving directory '/usr/local/share/mercurial/doc'

The workaround is to run gmake install-bin.

The man page for 10.14 says this is to copy the file and is only for
compatability, as it is the default. The CentOS 7 man page says it is ignored.
The top level makefile doesn't use this argument at all, so I'm not sure why
it's here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Apr 15 2020, 10:28 PM
mharbison72 added a comment.Apr 15 2020, 10:37 PM

This helps it get further, but then it dies with messages like:

find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/32/
...
install: hg-ssh.8 was not found anywhere!
find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/32/
...
install: hgrc.5 was not found anywhere!
...
mharbison72 added a comment.Apr 15 2020, 10:50 PM
In D8439#125864, @mharbison72 wrote:

This helps it get further, but then it dies with messages like:

find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/32/
...
install: hg-ssh.8 was not found anywhere!
find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/32/
...
install: hgrc.5 was not found anywhere!
...

... and gmake INSTALL=ginstall install works around that. But I think this patch is still valid.

mharbison72 added a commit: rHGeb9026a84e83: make: drop the `-c` arg to `install` in the documentation makefile.Apr 16 2020, 12:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGeb9026a84e83: make: drop the `-c` arg to `install` in the documentation makefile (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdoc/Makefile (2 lines)

Diff 21138

doc/Makefile

SOURCES=$(notdir $(wildcard ../mercurial/helptext/*.[0-9].txt)) SOURCES=$(notdir $(wildcard ../mercurial/helptext/*.[0-9].txt))
MAN=$(SOURCES:%.txt=%) MAN=$(SOURCES:%.txt=%)
HTML=$(SOURCES:%.txt=%.html) HTML=$(SOURCES:%.txt=%.html)
GENDOC=gendoc.py ../mercurial/commands.py ../mercurial/help.py \ GENDOC=gendoc.py ../mercurial/commands.py ../mercurial/help.py \
../mercurial/helptext/*.txt ../hgext/*.py ../hgext/*/__init__.py ../mercurial/helptext/*.txt ../hgext/*.py ../hgext/*/__init__.py
PREFIX=/usr/local PREFIX=/usr/local
MANDIR=$(PREFIX)/share/man MANDIR=$(PREFIX)/share/man
INSTALL=install -c -m 644 INSTALL=install -m 644
PYTHON?=python PYTHON?=python
RSTARGS= RSTARGS=
export HGENCODING=UTF-8 export HGENCODING=UTF-8
all: man html all: man html
man: $(MAN) man: $(MAN)