This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8451

rust: add option of static linking a local Re2 install
ClosedPublic

Authored by Alphare on Apr 16 2020, 11:38 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG97c10b157665: rust: add option of static linking a local Re2 install
Summary

Previously, only dynamically linking the system-wide install was possible.
We force the user to provide one to prevent hard-to-track errors.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Apr 16 2020, 11:38 AM
Alphare added a commit: rHG97c10b157665: rust: add option of static linking a local Re2 install.Apr 16 2020, 12:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG97c10b157665: rust: add option of static linking a local Re2 install (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/build.rs (44 lines)

Diff 21130

rust/hg-core/build.rs

// build.rs // build.rs
// //
// Copyright 2020 Raphaël Gomès <rgomes@octobus.net> // Copyright 2020 Raphaël Gomès <rgomes@octobus.net>
// //
// This software may be used and distributed according to the terms of the // This software may be used and distributed according to the terms of the
// GNU General Public License version 2 or any later version. // GNU General Public License version 2 or any later version.
#[cfg(feature = "with-re2")] #[cfg(feature = "with-re2")]
use cc; use cc;
/// Uses either the system Re2 install as a dynamic library or the provided
/// build as a static library
#[cfg(feature = "with-re2")] #[cfg(feature = "with-re2")]
fn compile_re2() { fn compile_re2() {
cc::Build::new() use cc;
use std::path::Path;
use std::process::exit;
let msg = r"HG_RE2_PATH must be one of `system|<path to build source clone of Re2>`";
let re2 = match std::env::var_os("HG_RE2_PATH") {
None => {
eprintln!("{}", msg);
exit(1)
}
Some(v) => {
if v == "system" {
None
} else {
Some(v)
}
}
};
let mut options = cc::Build::new();
options
.cpp(true) .cpp(true)
.flag("-std=c++11") .flag("-std=c++11")
.file("src/re2/rust_re2.cpp") .file("src/re2/rust_re2.cpp");
.compile("librustre.a");
if let Some(ref source) = re2 {
options.include(Path::new(source));
};
options.compile("librustre.a");
if let Some(ref source) = &re2 {
// Link the local source statically
println!(
"cargo:rustc-link-search=native={}",
Path::new(source).join(Path::new("obj")).display()
);
println!("cargo:rustc-link-lib=static=re2");
} else {
println!("cargo:rustc-link-lib=re2"); println!("cargo:rustc-link-lib=re2");
} }
}
fn main() { fn main() {
#[cfg(feature = "with-re2")] #[cfg(feature = "with-re2")]
compile_re2(); compile_re2();
} }