Page MenuHomePhabricator

locking: wait for locks in `hg cp` and `hg mv`
ClosedPublic

Authored by spectral on Apr 21 2020, 4:49 PM.

Details

Summary

I traced this back to revision 1822 (64df422), and there's no explanation why we
would prefer to error out instead of waiting for the locks.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Apr 21 2020, 4:49 PM
marmoute accepted this revision.Apr 22 2020, 3:57 AM
marmoute added a subscriber: marmoute.

Maybe because you can't be sure the situation will be the same as the one before you ran the command ? However, normal race condition could still happens so that would not seems like a strong enough reason ? With the current code coverning the full command execution, I feel like this change is fine.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.