This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8492

rust-matchers: add TODO about incomplete `Display` for `IncludeMatcher`
ClosedPublic

Authored by Alphare on May 6 2020, 9:11 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGde0fb4463a3d: rust-matchers: add TODO about incomplete `Display` for `IncludeMatcher`
Summary

This is purely for future reference, I don't think this is a problem right now,
since the Display is *only* used to ease debugging and has no real users.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.May 6 2020, 9:11 AM
Alphare added a commit: rHGde0fb4463a3d: rust-matchers: add TODO about incomplete `Display` for `IncludeMatcher`.May 7 2020, 2:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGde0fb4463a3d: rust-matchers: add TODO about incomplete `Display` for `IncludeMatcher` (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/matchers.rs (6 lines)

Diff 21269

rust/hg-core/src/matchers.rs

.chain(self.roots.iter()) .chain(self.roots.iter())
.chain(self.parents.iter()); .chain(self.parents.iter());
DirsChildrenMultiset::new(thing, Some(&self.parents)) DirsChildrenMultiset::new(thing, Some(&self.parents))
} }
} }
impl<'a> Display for IncludeMatcher<'a> { impl<'a> Display for IncludeMatcher<'a> {
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), Error> { fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), Error> {
// XXX What about exact matches?
// I'm not sure it's worth it to clone the HashSet and keep it
// around just in case someone wants to display the matcher, plus
// it's going to be unreadable after a few entries, but we need to
// inform in this display that exact matches are being used and are
// (on purpose) missing from the `includes`.
write!( write!(
f, f,
"IncludeMatcher(includes='{}')", "IncludeMatcher(includes='{}')",
String::from_utf8_lossy(&self.patterns.escaped_bytes()) String::from_utf8_lossy(&self.patterns.escaped_bytes())
) )
} }
} }