This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8511

status: use cmdutil.check_at_most_one_arg() for checking --rev/--change
ClosedPublic

Authored by martinvonz on May 8 2020, 12:00 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG07a6a29d25ea: status: use cmdutil.check_at_most_one_arg() for checking --rev/--change
Summary

There are apparently no tests for this either.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.May 8 2020, 12:00 PM
martinvonz added a commit: rHG07a6a29d25ea: status: use cmdutil.check_at_most_one_arg() for checking --rev/--change.May 11 2020, 5:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG07a6a29d25ea: status: use cmdutil.check_at_most_one_arg() for checking --rev/--change (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (6 lines)

Diff 21338

mercurial/commands.py

added, removed, modified, deleted, and untracked paths:: added, removed, modified, deleted, and untracked paths::
hg status -v -t mardu hg status -v -t mardu
Returns 0 on success. Returns 0 on success.
""" """
cmdutil.check_at_most_one_arg(opts, 'rev', 'change')
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
revs = opts.get(b'rev') revs = opts.get(b'rev')
change = opts.get(b'change') change = opts.get(b'change')
terse = opts.get(b'terse') terse = opts.get(b'terse')
if terse is _NOTTERSE: if terse is _NOTTERSE:
if revs: if revs:
terse = b'' terse = b''
else: else:
terse = ui.config(b'commands', b'status.terse') terse = ui.config(b'commands', b'status.terse')
if revs and change: if revs and terse:
msg = _(b'cannot specify --rev and --change at the same time')
raise error.Abort(msg)
elif revs and terse:
msg = _(b'cannot use --terse with --rev') msg = _(b'cannot use --terse with --rev')
raise error.Abort(msg) raise error.Abort(msg)
elif change: elif change:
repo = scmutil.unhidehashlikerevs(repo, [change], b'nowarn') repo = scmutil.unhidehashlikerevs(repo, [change], b'nowarn')
ctx2 = scmutil.revsingle(repo, change, None) ctx2 = scmutil.revsingle(repo, change, None)
ctx1 = ctx2.p1() ctx1 = ctx2.p1()
else: else:
repo = scmutil.unhidehashlikerevs(repo, revs, b'nowarn') repo = scmutil.unhidehashlikerevs(repo, revs, b'nowarn')