This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8520

status: also support for `traversedir` callback in the Rust fast-path
ClosedPublic

Authored by Alphare on May 12 2020, 7:51 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4ba2a6ffcf24: status: also support for `traversedir` callback in the Rust fast-path
Summary

Repeating the performance numbers from the hg-core change:

Running hg clean/purge on Netbeans' repo (100k files):

     | No-op | 30% unknown
--------------------------
Rust | 1.0s  | 1.67s
C    | 2.0s  | 2.87s

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.May 12 2020, 7:51 AM
Alphare added a commit: rHG4ba2a6ffcf24: status: also support for `traversedir` callback in the Rust fast-path.May 14 2020, 4:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG4ba2a6ffcf24: status: also support for `traversedir` callback in the Rust fast-path (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21382

mercurial/dirstate.py

added, added,
removed, removed,
deleted, deleted,
clean, clean,
ignored, ignored,
unknown, unknown,
warnings, warnings,
bad, bad,
traversed,
) = rustmod.status( ) = rustmod.status(
self._map._rustmap, self._map._rustmap,
matcher, matcher,
self._rootdir, self._rootdir,
self._ignorefiles(), self._ignorefiles(),
self._checkexec, self._checkexec,
self._lastnormaltime, self._lastnormaltime,
bool(list_clean), bool(list_clean),
bool(list_ignored), bool(list_ignored),
bool(list_unknown), bool(list_unknown),
bool(matcher.traversedir),
) )
if matcher.traversedir:
for dir in traversed:
matcher.traversedir(dir)
if self._ui.warn: if self._ui.warn:
for item in warnings: for item in warnings:
if isinstance(item, tuple): if isinstance(item, tuple):
file_path, syntax = item file_path, syntax = item
msg = _(b"%s: ignoring invalid syntax '%s'\n") % ( msg = _(b"%s: ignoring invalid syntax '%s'\n") % (
file_path, file_path,
syntax, syntax,
) )
use_rust = False use_rust = False
elif self._checkcase: elif self._checkcase:
# Case-insensitive filesystems are not handled yet # Case-insensitive filesystems are not handled yet
use_rust = False use_rust = False
elif subrepos: elif subrepos:
use_rust = False use_rust = False
elif sparse.enabled: elif sparse.enabled:
use_rust = False use_rust = False
elif match.traversedir is not None:
use_rust = False
elif not isinstance(match, allowed_matchers): elif not isinstance(match, allowed_matchers):
# Some matchers have yet to be implemented # Some matchers have yet to be implemented
use_rust = False use_rust = False
if use_rust: if use_rust:
try: try:
return self._rust_status( return self._rust_status(
match, listclean, listignored, listunknown match, listclean, listignored, listunknown