( )⚙ D8545 grep: grep the working copy faster

This is an archive of the discontinued Mercurial Phabricator instance.

grep: grep the working copy faster
ClosedPublic

Authored by valentin.gatienbaron on May 17 2020, 8:48 PM.

Details

Summary

hg grep qqqq in the mercurial repo:
before: 0,859s
after: 0,233s

hg grep somethingwithnomatch in mozilla-central:
before: 51s
after: 19s

This is probably also a tiny bug fix, because the code was looking up
a node for filename pfn on a filelog for filename fn, which are
most of the time the same filename, but don't have to be.

Ignoring performance and the bug fix, the code should have the same
behavior.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.