This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8600

scmutil: clarify getuipathfn comment
ClosedPublic

Authored by valentin.gatienbaron on May 30 2020, 10:05 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGd044b66d8429: scmutil: clarify getuipathfn comment

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg accepted this revision.May 30 2020, 12:21 PM
This revision is now accepted and ready to land.May 30 2020, 12:21 PM
valentin.gatienbaron added a commit: rHGd044b66d8429: scmutil: clarify getuipathfn comment.May 30 2020, 12:24 PM
Closed by commit rHGd044b66d8429: scmutil: clarify getuipathfn comment (authored by valentin.gatienbaron). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (4 lines)

Diff 21535

mercurial/scmutil.py

if relative is None: if relative is None:
raise error.ConfigError( raise error.ConfigError(
_(b"ui.relative-paths is not a boolean ('%s')") % config _(b"ui.relative-paths is not a boolean ('%s')") % config
) )
if relative: if relative:
cwd = repo.getcwd() cwd = repo.getcwd()
if cwd != b'': if cwd != b'':
# this branch is correct when cwd == b'', ie cwd = repo root, # this branch would work even if cwd == b'' (ie cwd = repo
# but it's slower # root), but its generality makes the returned function slower
pathto = repo.pathto pathto = repo.pathto
return lambda f: pathto(f, cwd) return lambda f: pathto(f, cwd)
if repo.ui.configbool(b'ui', b'slash'): if repo.ui.configbool(b'ui', b'slash'):
return lambda f: f return lambda f: f
else: else:
return util.localpath return util.localpath