Page MenuHomePhabricator

rust: do a clippy pass
ClosedPublic

Authored by Alphare on Jun 15 2020, 1:55 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG26114bd6ec60: rust: do a clippy pass
Summary

This is the result of running cargo clippy on hg-core/hg-cpython and fixing
the lints that do not require too much code churn (and would warrant a separate
commit/complete refactor) and only come from our code (a lot of warnings in
hg-cpython come from rust-cpython).

Most of those were good lints, two of them was the linter not being smart
enough (or compiler to get up to clippy's level depending on how you see it).

Maybe in the future we could have clippy be part of the CI.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Jun 15 2020, 1:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.