This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8671

version: sort extensions by name in verbose mode
ClosedPublic

Authored by mharbison72 on Jun 28 2020, 3:28 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGe1ea913da2ed: version: sort extensions by name in verbose mode
Summary

External extensions can be assigned any name, but presumably most enabled
extensions will be internal ones and having them sorted makes it easier to find
specific ones if the list is long. The lists in hg help extensions are
already sorted.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jun 28 2020, 3:28 PM
pulkit accepted this revision.Jun 29 2020, 4:44 AM
This revision is now accepted and ready to land.Jun 29 2020, 4:44 AM
mharbison72 added a commit: rHGe1ea913da2ed: version: sort extensions by name in verbose mode.Jun 29 2020, 6:31 AM
Closed by commit rHGe1ea913da2ed: version: sort extensions by name in verbose mode (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (2 lines)
Mtests/test-extension.t (4 lines)

Diff 21725

mercurial/commands.py

fm.plain(license) fm.plain(license)
if ui.verbose: if ui.verbose:
fm.plain(_(b"\nEnabled extensions:\n\n")) fm.plain(_(b"\nEnabled extensions:\n\n"))
# format names and versions into columns # format names and versions into columns
names = [] names = []
vers = [] vers = []
isinternals = [] isinternals = []
for name, module in extensions.extensions(): for name, module in sorted(extensions.extensions()):
names.append(name) names.append(name)
vers.append(extensions.moduleversion(module) or None) vers.append(extensions.moduleversion(module) or None)
isinternals.append(extensions.ismoduleinternal(module)) isinternals.append(extensions.ismoduleinternal(module))
fn = fm.nested(b"extensions", tmpl=b'{name}\n') fn = fm.nested(b"extensions", tmpl=b'{name}\n')
if names: if names:
namefmt = b" %%-%ds " % max(len(n) for n in names) namefmt = b" %%-%ds " % max(len(n) for n in names)
places = [_(b"external"), _(b"internal")] places = [_(b"external"), _(b"internal")]
for n, v, p in zip(names, vers, isinternals): for n, v, p in zip(names, vers, isinternals):

tests/test-extension.t

(see https://mercurial-scm.org for more information) (see https://mercurial-scm.org for more information)
Copyright (C) 2005-* Matt Mackall and others (glob) Copyright (C) 2005-* Matt Mackall and others (glob)
This is free software; see the source for copying conditions. There is NO This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Enabled extensions: Enabled extensions:
throw external 1.twentythree
strip internal strip internal
throw external 1.twentythree
$ hg version -q --config extensions.throw=throw.py $ hg version -q --config extensions.throw=throw.py
Mercurial Distributed SCM (version *) (glob) Mercurial Distributed SCM (version *) (glob)
Test template output: Test template output:
$ hg version --config extensions.strip= -T'{extensions}' $ hg version --config extensions.strip= -T'{extensions}'
strip strip
"ver": "*" (glob) "ver": "*" (glob)
} }
] ]
Test template output of version: Test template output of version:
$ hg version --config extensions.throw=throw.py --config extensions.strip= \ $ hg version --config extensions.throw=throw.py --config extensions.strip= \
> -T'{extensions % "{name} {pad(ver, 16)} ({if(bundled, "internal", "external")})\n"}' > -T'{extensions % "{name} {pad(ver, 16)} ({if(bundled, "internal", "external")})\n"}'
throw 1.twentythree (external)
strip (internal) strip (internal)
throw 1.twentythree (external)
Refuse to load extensions with minimum version requirements Refuse to load extensions with minimum version requirements
$ cat > minversion1.py << EOF $ cat > minversion1.py << EOF
> from mercurial import util > from mercurial import util
> util.version = lambda: b'3.5.2' > util.version = lambda: b'3.5.2'
> minimumhgversion = b'3.6' > minimumhgversion = b'3.6'
> EOF > EOF