This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8676

tests: allow timing difference in output
ClosedPublic

Authored by joerg.sonnenberger on Jul 2 2020, 2:00 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGbaffdfa5bd1a: tests: allow timing difference in output
rHG3990a56491fd: tests: allow timing difference in output

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit added a subscriber: pulkit.Jul 7 2020, 2:11 PM

Seems like I know why this patch is required but some additional description in commit message as why this is required will be helpful.

joerg.sonnenberger added a comment.Jul 7 2020, 3:35 PM

I don't have a good explanation for why we see it, just that it is a coin flip under load for me. Otherwise I would have gone into more details.

pulkit accepted this revision.Jul 10 2020, 6:00 AM
This revision is now accepted and ready to land.Jul 10 2020, 6:00 AM
joerg.sonnenberger added a commit: rHG3990a56491fd: tests: allow timing difference in output.Jul 10 2020, 6:45 AM
Closed by commit rHG3990a56491fd: tests: allow timing difference in output (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21823

tests/test-wireproto-exchangev2-shallow.t

'roots': [], 'roots': [],
'type': 'changesetdagrange' 'type': 'changesetdagrange'
} }
] ]
} }
received frame(size=9; request=1; stream=2; streamflags=stream-begin; type=stream-settings; flags=eos) received frame(size=9; request=1; stream=2; streamflags=stream-begin; type=stream-settings; flags=eos)
received frame(size=11; request=1; stream=2; streamflags=encoded; type=command-response; flags=continuation) received frame(size=11; request=1; stream=2; streamflags=encoded; type=command-response; flags=continuation)
received frame(size=1170; request=1; stream=2; streamflags=encoded; type=command-response; flags=continuation) received frame(size=1170; request=1; stream=2; streamflags=encoded; type=command-response; flags=continuation)
received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos) received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos) (?)
add changeset 3390ef850073 add changeset 3390ef850073
add changeset b709380892b1 add changeset b709380892b1
add changeset 47fe012ab237 add changeset 47fe012ab237
add changeset 97765fc3cd62 add changeset 97765fc3cd62
add changeset dc666cf9ecf3 add changeset dc666cf9ecf3
add changeset 93a8bd067ed2 add changeset 93a8bd067ed2
received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos) (?)
checking for updated bookmarks checking for updated bookmarks
sending 1 commands sending 1 commands
sending command manifestdata: { sending command manifestdata: {
'fields': set([ 'fields': set([
'parents', 'parents',
'revision' 'revision'
]), ]),
'haveparents': True, 'haveparents': True,