This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8720

tests: stablize test-serve.t on Windows
ClosedPublic

Authored by mharbison72 on Jul 9 2020, 11:12 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG9a062913bab6: tests: stablize test-serve.t on Windows
rHG8c06f479cfc1: tests: stablize test-serve.t on Windows
Summary

I forget the reason that the subprocess on Windows doesn't print this, but all
other instances of this are similarly conditionalized, so I didn't think too
hard about it.

Also, the server needs to be killed so it doesn't prevent the next run from
working, especially since the port isn't randomized.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jul 9 2020, 11:12 PM
pulkit accepted this revision.Jul 10 2020, 6:08 AM
This revision is now accepted and ready to land.Jul 10 2020, 6:08 AM
mharbison72 added a commit: rHG8c06f479cfc1: tests: stablize test-serve.t on Windows.Jul 10 2020, 6:47 AM
Closed by commit rHG8c06f479cfc1: tests: stablize test-serve.t on Windows (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-serve.t (7 lines)

Diff 21830

tests/test-serve.t

$ cat access.log errors.log $ cat access.log errors.log
$LOCALIP - - [$LOGDATE$] "GET /some/dir7?cmd=capabilities HTTP/1.1" 404 - (glob) $LOCALIP - - [$LOGDATE$] "GET /some/dir7?cmd=capabilities HTTP/1.1" 404 - (glob)
$LOCALIP - - [$LOGDATE$] "GET /some?cmd=capabilities HTTP/1.1" 404 - (glob) $LOCALIP - - [$LOGDATE$] "GET /some?cmd=capabilities HTTP/1.1" 404 - (glob)
$ "$PYTHON" $RUNTESTDIR/killdaemons.py $DAEMON_PIDS $ "$PYTHON" $RUNTESTDIR/killdaemons.py $DAEMON_PIDS
issue6362: Previously, this crashed on Python 3 issue6362: Previously, this crashed on Python 3
$ hg serve -a 0.0.0.0 -d $ hg serve -a 0.0.0.0 -d --pid-file=hg.pid
listening at http://*:$HGPORT1/ (bound to *:$HGPORT1) (glob) listening at http://*:$HGPORT1/ (bound to *:$HGPORT1) (glob) (?)
$ cat hg.pid > "$DAEMON_PIDS"
$ "$PYTHON" $RUNTESTDIR/killdaemons.py $DAEMON_PIDS
$ cd .. $ cd ..