This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8813

tests: make test-install.t work on debian systems
ClosedPublic

Authored by spectral on Jul 24 2020, 6:25 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGd71693f799a0: tests: make test-install.t work on debian systems
Summary

Debian systems, at least as of their version of python3.8 on my machine, have
rewritten some logic in ensurepip to make it not use the wheels in pip._bundled,
but instead to use wheels installed in /usr/share/python-wheels. It copies these
wheels into the virtual environment when it's created, and installenv/bin/pip is
able to see them and use them, so it thinks that 'wheel' is installed, and that
it can build the mercurial wheel instead of just installing it. For some reason,
when it subprocesses to run python3 setup.py bdist_wheel, it setup.py does
*not* have the 'wheel' wheel available, and we get an error message.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Jul 24 2020, 6:25 PM
indygreg accepted this revision.Aug 8 2020, 4:32 PM
indygreg added a subscriber: indygreg.

Debian's perturbations to how Python is packaged continue to confound me. There's aren't enough Picard facepalm memes to express my feelings on the matter.

This revision is now accepted and ready to land.Aug 8 2020, 4:32 PM
spectral added a commit: rHGd71693f799a0: tests: make test-install.t work on debian systems.Aug 8 2020, 5:01 PM
Closed by commit rHGd71693f799a0: tests: make test-install.t work on debian systems (authored by spectral). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-install.t (8 lines)

Diff 22367

tests/test-install.t

On Python 2, we use the 3rd party virtualenv module, if available. On Python 2, we use the 3rd party virtualenv module, if available.
$ cd $TESTTMP $ cd $TESTTMP
$ unset PYTHONPATH $ unset PYTHONPATH
#if py3 ensurepip #if py3 ensurepip
$ "$PYTHON" -m venv installenv >> pip.log $ "$PYTHON" -m venv installenv >> pip.log
Hack: Debian does something a bit different in ensurepip.bootstrap. This makes
it so that pip thinks the 'wheel' wheel is installed so it can build wheels;
when it goes to try, however, it shells out to run `python3 -u <setup.py>`,
that *doesn't* get the 'wheel' wheel, and it fails with an invalid command
'bdist_wheel'. To fix this, we just delete the wheel from where Debian put it in
our virtual env. Then pip doesn't think it's installed and doesn't try to build.
$ rm installenv/share/python-wheels/wheel-*.whl >/dev/null 2>&1 || true
Note: we use this weird path to run pip and hg to avoid platform differences, Note: we use this weird path to run pip and hg to avoid platform differences,
since it's bin on most platforms but Scripts on Windows. since it's bin on most platforms but Scripts on Windows.
$ ./installenv/*/pip install --no-index $TESTDIR/.. >> pip.log $ ./installenv/*/pip install --no-index $TESTDIR/.. >> pip.log
Failed building wheel for mercurial (?) Failed building wheel for mercurial (?)
$ ./installenv/*/hg debuginstall || cat pip.log $ ./installenv/*/hg debuginstall || cat pip.log
checking encoding (ascii)... checking encoding (ascii)...
checking Python executable (*) (glob) checking Python executable (*) (glob)
checking Python implementation (*) (glob) checking Python implementation (*) (glob)