This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8912

repository: introduce constant for internal phase repo requirement and use it
ClosedPublic

Authored by pulkit on Aug 7 2020, 8:45 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGf025b97f3758: repository: introduce constant for internal phase repo requirement and use it
Summary

In future we will like to much cleaner logic around which requirement is for
working copy and which can go in store. To start with that, we first need to
de-clutter the requirement values spread around and replace them with constants.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 22355

mercurial/interfaces/repository.py

# When narrowing is finalized and no longer subject to format changes, # When narrowing is finalized and no longer subject to format changes,
# we should move this to just "narrow" or similar. # we should move this to just "narrow" or similar.
NARROW_REQUIREMENT = b'narrowhg-experimental' NARROW_REQUIREMENT = b'narrowhg-experimental'
# Enables sparse working directory usage # Enables sparse working directory usage
SPARSE_REQUIREMENT = b'exp-sparse' SPARSE_REQUIREMENT = b'exp-sparse'
# Enables the internal phase which is used to hide changesets instead
# of stripping them
INTERNAL_PHASE_REQUIREMENT = b'internal-phase'
# Local repository feature string. # Local repository feature string.
# Revlogs are being used for file storage. # Revlogs are being used for file storage.
REPO_FEATURE_REVLOG_FILE_STORAGE = b'revlogfilestorage' REPO_FEATURE_REVLOG_FILE_STORAGE = b'revlogfilestorage'
# The storage part of the repository is shared from an external source. # The storage part of the repository is shared from an external source.
REPO_FEATURE_SHARED_STORAGE = b'sharedstore' REPO_FEATURE_SHARED_STORAGE = b'sharedstore'
# LFS supported for backing file storage. # LFS supported for backing file storage.
REPO_FEATURE_LFS = b'lfs' REPO_FEATURE_LFS = b'lfs'

mercurial/localrepo.py

} }
_basesupported = supportedformats | { _basesupported = supportedformats | {
b'store', b'store',
b'fncache', b'fncache',
b'shared', b'shared',
b'relshared', b'relshared',
b'dotencode', b'dotencode',
repository.SPARSE_REQUIREMENT, repository.SPARSE_REQUIREMENT,
b'internal-phase', repository.INTERNAL_PHASE_REQUIREMENT,
} }
# list of prefix for file which can be written without 'wlock' # list of prefix for file which can be written without 'wlock'
# Extensions should extend this list when needed # Extensions should extend this list when needed
_wlockfreeprefix = { _wlockfreeprefix = {
# We migh consider requiring 'wlock' for the next # We migh consider requiring 'wlock' for the next
# two, but pretty much all the existing code assume # two, but pretty much all the existing code assume
# wlock is not needed so we keep them excluded for # wlock is not needed so we keep them excluded for
revlogv2 = ui.config(b'experimental', b'revlogv2') revlogv2 = ui.config(b'experimental', b'revlogv2')
if revlogv2 == b'enable-unstable-format-and-corrupt-my-data': if revlogv2 == b'enable-unstable-format-and-corrupt-my-data':
requirements.remove(b'revlogv1') requirements.remove(b'revlogv1')
# generaldelta is implied by revlogv2. # generaldelta is implied by revlogv2.
requirements.discard(b'generaldelta') requirements.discard(b'generaldelta')
requirements.add(REVLOGV2_REQUIREMENT) requirements.add(REVLOGV2_REQUIREMENT)
# experimental config: format.internal-phase # experimental config: format.internal-phase
if ui.configbool(b'format', b'internal-phase'): if ui.configbool(b'format', b'internal-phase'):
requirements.add(b'internal-phase') requirements.add(repository.INTERNAL_PHASE_REQUIREMENT)
if createopts.get(b'narrowfiles'): if createopts.get(b'narrowfiles'):
requirements.add(repository.NARROW_REQUIREMENT) requirements.add(repository.NARROW_REQUIREMENT)
if createopts.get(b'lfs'): if createopts.get(b'lfs'):
requirements.add(b'lfs') requirements.add(b'lfs')
if ui.configbool(b'format', b'bookmarks-in-store'): if ui.configbool(b'format', b'bookmarks-in-store'):

mercurial/phases.py

) )
from . import ( from . import (
error, error,
pycompat, pycompat,
smartset, smartset,
txnutil, txnutil,
util, util,
) )
from .interfaces import repository
_fphasesentry = struct.Struct(b'>i20s') _fphasesentry = struct.Struct(b'>i20s')
# record phase index # record phase index
public, draft, secret = range(3) public, draft, secret = range(3)
archived = 32 # non-continuous for compatibility archived = 32 # non-continuous for compatibility
internal = 96 # non-continuous for compatibility internal = 96 # non-continuous for compatibility
allphases = (public, draft, secret, archived, internal) allphases = (public, draft, secret, archived, internal)
# record phase property # record phase property
mutablephases = (draft, secret, archived, internal) mutablephases = (draft, secret, archived, internal)
remotehiddenphases = (secret, archived, internal) remotehiddenphases = (secret, archived, internal)
localhiddenphases = (internal, archived) localhiddenphases = (internal, archived)
def supportinternal(repo): def supportinternal(repo):
"""True if the internal phase can be used on a repository""" """True if the internal phase can be used on a repository"""
return b'internal-phase' in repo.requirements return repository.INTERNAL_PHASE_REQUIREMENT in repo.requirements
def _readroots(repo, phasedefaults=None): def _readroots(repo, phasedefaults=None):
"""Read phase roots from disk """Read phase roots from disk
phasedefaults is a list of fn(repo, roots) callable, which are phasedefaults is a list of fn(repo, roots) callable, which are
executed if the phase roots file does not exist. When phases are executed if the phase roots file does not exist. When phases are
being initialized on an existing repository, this could be used to being initialized on an existing repository, this could be used to