( )⚙ D8969 extdiff: pass full paths of `dir1a` and `dir1b` to `_runperfilediff()`

This is an archive of the discontinued Mercurial Phabricator instance.

extdiff: pass full paths of `dir1a` and `dir1b` to `_runperfilediff()`
ClosedPublic

Authored by pulkit on Aug 29 2020, 10:11 AM.

Details

Summary

Earlier we were passing basename instead of the fullpath and then joining with
the tmproot. This is wrong because the user can choose rev1a as wdir and in
those cases, tmproot should not be joined with the path.

I am working on refactoring extdiff logic so that we can have options like `diff
--tool` and encountered this. Although this patch in itself makes no difference,
however in future when a new caller of _runperfilediff() will be added, it
will be useful to directly pass on the full paths instead.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Aug 29 2020, 10:11 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.