( )⚙ D8970 extdiff: remove dir2root and pass full path as dir2 in _runperfilediff()

This is an archive of the discontinued Mercurial Phabricator instance.

extdiff: remove dir2root and pass full path as dir2 in _runperfilediff()
ClosedPublic

Authored by pulkit on Aug 29 2020, 10:12 AM.

Details

Summary

The only use of dir2root was to join with dir2 to generate the path for
other side of diff. Like in previous patch, dir1a and dir1b are full paths
and no longer base names, hence we pass dir2 as full path too and making
dir2root unrequired.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Aug 29 2020, 10:12 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.