This is an archive of the discontinued Mercurial Phabricator instance.

Differential D901

changelog: use a Factory for default value for files
ClosedPublic

Authored by indygreg on Oct 2 2017, 6:05 AM.

Details

Reviewers
lothiraldan
Group Reviewers
hg-reviewers
Commits
rHG50474f0b3f1b: changelog: use a Factory for default value for files
Summary

The default value is compiled into the generated type. This means
that default values are shared between instances. For immutable types
like bool, str, int, and tuple, this is fine. But for mutable types
like list and dict, we need to use attr.Factory() to instantiate a
new instance of the default for each object.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 2 2017, 6:05 AM
lothiraldan accepted this revision.Oct 2 2017, 1:21 PM
lothiraldan added a subscriber: lothiraldan.

Looks good to me and seems coherent with what attr documentation recommends.

Closed by commit rHG50474f0b3f1b: changelog: use a Factory for default value for files (authored by indygreg). · Explain WhyOct 4 2017, 9:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (2 lines)

Diff 2398

mercurial/changelog.py

@attr.s @attr.s
class _changelogrevision(object): class _changelogrevision(object):
# Extensions might modify _defaultextra, so let the constructor below pass # Extensions might modify _defaultextra, so let the constructor below pass
# it in # it in
extra = attr.ib() extra = attr.ib()
manifest = attr.ib(default=nullid) manifest = attr.ib(default=nullid)
user = attr.ib(default='') user = attr.ib(default='')
date = attr.ib(default=(0, 0)) date = attr.ib(default=(0, 0))
files = attr.ib(default=[]) files = attr.ib(default=attr.Factory(list))
description = attr.ib(default='') description = attr.ib(default='')
class changelogrevision(object): class changelogrevision(object):
"""Holds results of a parsed changelog revision. """Holds results of a parsed changelog revision.
Changelog revisions consist of multiple pieces of data, including Changelog revisions consist of multiple pieces of data, including
the manifest node, user, and date. This object exposes a view into the manifest node, user, and date. This object exposes a view into
the parsed object. the parsed object.