This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9095

hg-core: Explain offset override of first revision
ClosedPublic

Authored by acezar on Sep 28 2020, 9:47 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGf38adf8b0711: hg-core: Explain offset override of first revision
Summary

(D8958#inline-14992 followup)

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

acezar created this revision.Sep 28 2020, 9:47 AM
Alphare accepted this revision.Sep 28 2020, 10:07 AM
Alphare added a subscriber: Alphare.

Nits:

s/for index's/for the index's/
s/alway/always/

acezar updated this revision to Diff 22894.Sep 28 2020, 10:18 AM
Alphare accepted this revision.Sep 28 2020, 10:27 AM
acezar retitled this revision from hg-core: Explain offset override of first revision (D8958#inline-14992 followup) to hg-core: Explain offset override of first revision.Sep 29 2020, 11:53 AM
acezar edited the summary of this revision. (Show Details)
Antoine cezar <acezar@chwitlabs.fr> added a commit: rHGf38adf8b0711: hg-core: Explain offset override of first revision.Sep 29 2020, 1:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGf38adf8b0711: hg-core: Explain offset override of first revision (authored by Antoine cezar <acezar@chwitlabs.fr>). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/revlog/index.rs (3 lines)

Diff 22881

rust/hg-core/src/revlog/index.rs

let max_rev = self.bytes.len() / INDEX_ENTRY_SIZE; let max_rev = self.bytes.len() / INDEX_ENTRY_SIZE;
if rev as usize >= max_rev { if rev as usize >= max_rev {
return None; return None;
} }
let start = rev as usize * INDEX_ENTRY_SIZE; let start = rev as usize * INDEX_ENTRY_SIZE;
let end = start + INDEX_ENTRY_SIZE; let end = start + INDEX_ENTRY_SIZE;
let bytes = &self.bytes[start..end]; let bytes = &self.bytes[start..end];
// See IndexEntry for an explanation of this override. // Override the offset of the first revision as its bytes are used
// for index's metadata (saving space because it is alway 0)
let offset_override = match rev { let offset_override = match rev {
0 => Some(0), 0 => Some(0),
_ => None, _ => None,
}; };
Some(IndexEntry { Some(IndexEntry {
bytes, bytes,
offset_override, offset_override,