This is an archive of the discontinued Mercurial Phabricator instance.

Differential D911

test-pager: make it compatible with chg
ClosedPublic

Authored by quark on Oct 2 2017, 7:12 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG73d8a5283f87: test-pager: make it compatible with chg
Summary

chg's runpager implementation is different. It behaves differently for the
"shell=False, command not found" case.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Oct 2 2017, 7:12 PM
quark retitled this revision from test-pager: make it work with chg to test-pager: make it compatible with chg.Oct 2 2017, 11:23 PM
Closed by commit rHG73d8a5283f87: test-pager: make it compatible with chg (authored by quark). · Explain WhyOct 4 2017, 9:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-pager.t (12 lines)

Diff 2397

tests/test-pager.t

paged! 'summary: modify a 9\n' paged! 'summary: modify a 9\n'
paged! '\n' paged! '\n'
paged! '\x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m\n' paged! '\x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m\n'
paged! 'user: test\n' paged! 'user: test\n'
paged! 'date: Thu Jan 01 00:00:00 1970 +0000\n' paged! 'date: Thu Jan 01 00:00:00 1970 +0000\n'
paged! 'summary: modify a 8\n' paged! 'summary: modify a 8\n'
paged! '\n' paged! '\n'
#if no-chg
An invalid pager command name is reported sensibly if we don't have to An invalid pager command name is reported sensibly if we don't have to
use shell=True in the subprocess call: use shell=True in the subprocess call:
$ hg log --limit 3 --config pager.pager=this-command-better-never-exist $ hg log --limit 3 --config pager.pager=this-command-better-never-exist
missing pager command 'this-command-better-never-exist', skipping pager missing pager command 'this-command-better-never-exist', skipping pager
\x1b[0;33mchangeset: 10:46106edeeb38\x1b[0m (esc) \x1b[0;33mchangeset: 10:46106edeeb38\x1b[0m (esc)
tag: tip tag: tip
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: modify a 10 summary: modify a 10
\x1b[0;33mchangeset: 9:6dd8ea7dd621\x1b[0m (esc) \x1b[0;33mchangeset: 9:6dd8ea7dd621\x1b[0m (esc)
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: modify a 9 summary: modify a 9
\x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m (esc) \x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m (esc)
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: modify a 8 summary: modify a 8
#else
Currently, chg has its own runpager implementation, which does not show the
"missing pager" message. The error message is globed out since the shell could
print different message.
$ hg log --limit 3 --config pager.pager=this-command-better-never-exist
/bin/sh: this-command-better-never-exist: command not found (?)
* (glob) (?)
killed!
[255]
#endif
A complicated pager command gets worse behavior. Bonus points if you can A complicated pager command gets worse behavior. Bonus points if you can
improve this. improve this.
$ hg log --limit 3 \ $ hg log --limit 3 \
> --config pager.pager='this-command-better-never-exist --seriously' \ > --config pager.pager='this-command-better-never-exist --seriously' \
> 2>/dev/null || true > 2>/dev/null || true
Pager works with shell aliases. Pager works with shell aliases.