This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1128

test-pager: make the test compatible with chg
ClosedPublic

Authored by singhsrb on Oct 16 2017, 8:42 PM.

Details

Reviewers
quark
durin42
Group Reviewers
hg-reviewers
Commits
rHG03033e44ff5d: test-pager: make the test compatible with chg
rHG4effa078d157: test-pager: make the test compatible with chg
Summary

D911 tried to make this test compatible with chg but instead resulted
in the test being flaky for chg. For now, disabling this test for chg because
it seems difficult to fix the test. This will allow for the continuous build
setup for chg.

Test Plan

Ran the test 'test-pager.t' with and without the '--chg' option.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Oct 16 2017, 8:42 PM
quark accepted this revision.Oct 16 2017, 9:29 PM
quark added a subscriber: quark.

This was suggested by me. Basically there are too many "racy" cases that errors can happen everywhere, ex. chg cannot send fds, etc. And the "killed!" output is also racy that it may appear before or after a chg error message.

Instead of trying to match all possible outputs, it is cleaner to just remove the test until we implement something similar to core hg to not execute the shell.

durin42 added a subscriber: durin42.Oct 16 2017, 9:33 PM

It's probably worth pointing out that the "killed!" message is racy on solaris, which probably means it's just straight-up racy and Linux/FreeBSD/OS X aren't annoying enough to trigger the race on a regular basis....

durin42 accepted this revision.Oct 16 2017, 9:33 PM
This revision is now accepted and ready to land.Oct 16 2017, 9:33 PM
Closed by commit rHG4effa078d157: test-pager: make the test compatible with chg (authored by singhsrb). · Explain WhyOct 16 2017, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-pager.t (10 lines)

Diff 2871

tests/test-pager.t

date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: modify a 9 summary: modify a 9
\x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m (esc) \x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m (esc)
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: modify a 8 summary: modify a 8
#else
Currently, chg has its own runpager implementation, which does not show the
"missing pager" message. The error message is globed out since the shell could
print different message.
$ hg log --limit 3 --config pager.pager=this-command-better-never-exist
/bin/sh: this-command-better-never-exist: command not found (?)
* (glob) (?)
killed!
[255]
#endif #endif
A complicated pager command gets worse behavior. Bonus points if you can A complicated pager command gets worse behavior. Bonus points if you can
improve this. improve this.
$ hg log --limit 3 \ $ hg log --limit 3 \
> --config pager.pager='this-command-better-never-exist --seriously' \ > --config pager.pager='this-command-better-never-exist --seriously' \
> 2>/dev/null || true > 2>/dev/null || true