This is an archive of the discontinued Mercurial Phabricator instance.

Differential D912

test-alias: make it compatible with chg
ClosedPublic

Authored by quark on Oct 2 2017, 7:59 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGa8a9c0d3232b: test-alias: make it compatible with chg
Summary

ad1bdea (dispatch: defer environment variable resolution in alias commands
(BC), 2016-05-06) made environment variables lazily resolved. But after
D805 (alias: make alias command lazily resolved 2017-09-23), alias
resolution happened after uisetup, which breaks the test for chg.

uisetup is known to behave different in chg. Let's verify the feature
without using *setup.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Oct 2 2017, 7:59 PM
yuja requested changes to this revision.Oct 4 2017, 9:02 AM
yuja added a subscriber: yuja.

The test output doesn't look right. Maybe we should disable the test
on chg.

This revision now requires changes to proceed.Oct 4 2017, 9:02 AM
quark edited the summary of this revision. (Show Details)Oct 5 2017, 12:43 AM
quark updated this revision to Diff 2452.
Closed by commit rHGa8a9c0d3232b: test-alias: make it compatible with chg (authored by quark). · Explain WhyOct 5 2017, 10:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-alias.t (20 lines)

Diff 2462

tests/test-alias.t

summary summarize working directory state summary summarize working directory state
update update working directory (or switch revisions) update update working directory (or switch revisions)
(use 'hg help' for the full list of commands or 'hg -v' for details) (use 'hg help' for the full list of commands or 'hg -v' for details)
[255] [255]
environment variable changes in alias commands environment variable changes in alias commands
$ cat > $TESTTMP/setcount.py <<EOF $ cat > $TESTTMP/expandalias.py <<EOF
> import os > import os
> def uisetup(ui): > from mercurial import cmdutil, commands, registrar
> cmdtable = {}
> command = registrar.command(cmdtable)
> @command('expandalias')
> def expandalias(ui, repo, name):
> alias = cmdutil.findcmd(name, commands.table)[1][0]
> ui.write('%s args: %s\n' % (name, ' '.join(alias.args)))
> os.environ['COUNT'] = '2' > os.environ['COUNT'] = '2'
> ui.write('%s args: %s (with COUNT=2)\n' % (name, ' '.join(alias.args)))
> EOF > EOF
$ cat >> $HGRCPATH <<'EOF' $ cat >> $HGRCPATH <<'EOF'
> [extensions] > [extensions]
> setcount = $TESTTMP/setcount.py > expandalias = $TESTTMP/expandalias.py
> [alias] > [alias]
> showcount = log -T "$COUNT\n" -r . > showcount = log -T "$COUNT" -r .
> EOF > EOF
$ COUNT=1 hg showcount $ COUNT=1 hg expandalias showcount
2 showcount args: -T 1 -r .
showcount args: -T 2 -r . (with COUNT=2)
This should show id: This should show id:
$ hg --config alias.log='id' log $ hg --config alias.log='id' log
000000000000 tip 000000000000 tip
This shouldn't: This shouldn't: