This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9153

unbundle: free temporary objects after use
ClosedPublic

Authored by joerg.sonnenberger on Oct 5 2020, 7:52 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG44d84b726c8a: unbundle: free temporary objects after use
rHG3aa7b0c1b97c: unbundle: free temporary objects after use
Summary

This reduces peak RSS for larger unbundle operations by ~30 Bytes per
changeset on AMD64. This can't be a direct delete for Python 2.7, so
reset the object instead and leave a comment.

The efilesset object can't be deleted as it is referenced by the local
onchangelog function and Python 2.7 rejects a delete on the existance of
a nested scope.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit accepted this revision.Oct 6 2020, 4:35 AM
This revision is now accepted and ready to land.Oct 6 2020, 4:35 AM
joerg.sonnenberger added a commit: rHG3aa7b0c1b97c: unbundle: free temporary objects after use.Oct 12 2020, 2:11 PM
Closed by commit rHG3aa7b0c1b97c: unbundle: free temporary objects after use (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.
joerg.sonnenberger edited the summary of this revision. (Show Details)Oct 12 2020, 4:16 PM
joerg.sonnenberger updated this revision to Diff 23178.
joerg.sonnenberger edited the summary of this revision. (Show Details)Oct 12 2020, 6:36 PM
joerg.sonnenberger updated this revision to Diff 23179.
pulkit added a comment.Oct 13 2020, 4:08 AM

Dropping this patch as it breaks test and results in a synatx error. https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/112163

joerg.sonnenberger edited the summary of this revision. (Show Details)Oct 14 2020, 8:16 AM
joerg.sonnenberger added a comment.Oct 14 2020, 8:19 AM

Re-submitted the change in a way that the Python2.7 nested scope issue is avoided.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (4 lines)

Diff 23179

mercurial/changegroup.py

if not cgnodes: if not cgnodes:
repo.ui.develwarn( repo.ui.develwarn(
b'applied empty changelog from changegroup', b'applied empty changelog from changegroup',
config=b'warn-empty-changegroup', config=b'warn-empty-changegroup',
) )
clend = len(cl) clend = len(cl)
changesets = clend - clstart changesets = clend - clstart
progress.complete() progress.complete()
del deltas
# TODO Python 2.7 removal
# del efilesset
efilesset = None
self.callback = None self.callback = None
# pull off the manifest group # pull off the manifest group
repo.ui.status(_(b"adding manifests\n")) repo.ui.status(_(b"adding manifests\n"))
# We know that we'll never have more manifests than we had # We know that we'll never have more manifests than we had
# changesets. # changesets.
progress = repo.ui.makeprogress( progress = repo.ui.makeprogress(
_(b'manifests'), unit=_(b'chunks'), total=changesets _(b'manifests'), unit=_(b'chunks'), total=changesets