This is an archive of the discontinued Mercurial Phabricator instance.

commit: pass ChangingFiles object as argument to _process_files
ClosedPublic

Authored by pulkit on Oct 10 2020, 4:41 AM.

Details

Summary

Instead of returning it, we pass it as an argument. This makes the whole if-else
in _prepare_files a bit simpler. Else each if-else branch was creating the
object.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 10 2020, 4:41 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.