This is an archive of the discontinued Mercurial Phabricator instance.

Differential D924

config: add a missing preparewrite() call
ClosedPublic

Authored by quark on Oct 3 2017, 3:52 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG0efdfb57b05c: config: add a missing preparewrite() call
Summary

Thanks Yuya for pointing this out in D808.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Oct 3 2017, 3:52 PM
yuja accepted this revision.Oct 4 2017, 9:27 AM
yuja added a subscriber: yuja.

Queued, thanks.

This revision is now accepted and ready to land.Oct 4 2017, 9:27 AM
Closed by commit rHG0efdfb57b05c: config: add a missing preparewrite() call (authored by quark). · Explain WhyOct 4 2017, 9:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/config.py (1 line)

Diff 2410

mercurial/config.py

self.set(section, item, m.group(2), "%s:%d" % (src, line)) self.set(section, item, m.group(2), "%s:%d" % (src, line))
continue continue
m = unsetre.match(l) m = unsetre.match(l)
if m: if m:
name = m.group(1) name = m.group(1)
if sections and section not in sections: if sections and section not in sections:
continue continue
if self.get(section, name) is not None: if self.get(section, name) is not None:
self._data[section] = self._data[section].preparewrite()
del self._data[section][name] del self._data[section][name]
self._unset.append((section, name)) self._unset.append((section, name))
continue continue
raise error.ParseError(l.rstrip(), ("%s:%s" % (src, line))) raise error.ParseError(l.rstrip(), ("%s:%s" % (src, line)))
def read(self, path, fp=None, sections=None, remap=None): def read(self, path, fp=None, sections=None, remap=None):
if not fp: if not fp: