Page MenuHomePhabricator

histedit: drop fallback to empty string from rendertemplate()
ClosedPublic

Authored by martinvonz on Oct 23 2020, 2:43 AM.

Details

Summary

AFAICT, cmdutil.rendertemplate() always returns bytes (never
e.g. None), so we don't need to fall back to empty
(byte-)string. The fallback has been there since the code was added in
11c076786d56 (histedit: add templating support to histedit's rule file
generation, 2019-01-29).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 23 2020, 2:43 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.