This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9259

py3: hggettext
ClosedPublic

Authored by danchr on Oct 29 2020, 8:56 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGbea8cf87bef3: py3: hggettext
Summary

itervalues() is only available on Python 2. Since this script
doesn't currently refer to the main Mercurial modules, and as a result
doesn't have easy access to the pycompat module, I simply changed it
to use value() instead. Although this allocates a list on Python 2,
I'd consider that acceptable for a utility script; Mercurial doesn't
have all _that_ many commands anyway.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

danchr created this revision.Oct 29 2020, 8:56 AM
Dan Villiom Podlaski Christiansen <danchr@gmail.com> added a commit: rHGbea8cf87bef3: py3: hggettext.Oct 30 2020, 1:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGbea8cf87bef3: py3: hggettext (authored by Dan Villiom Podlaski Christiansen <danchr@gmail.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mi18n/hggettext (2 lines)

Diff 23377

i18n/hggettext

functions = list(getattr(mod, 'i18nfunctions', [])) functions = list(getattr(mod, 'i18nfunctions', []))
functions = [(f, True) for f in functions] functions = [(f, True) for f in functions]
cmdtable = getattr(mod, 'cmdtable', {}) cmdtable = getattr(mod, 'cmdtable', {})
if not cmdtable: if not cmdtable:
# Maybe we are processing mercurial.commands? # Maybe we are processing mercurial.commands?
cmdtable = getattr(mod, 'table', {}) cmdtable = getattr(mod, 'table', {})
functions.extend((c[0], False) for c in cmdtable.itervalues()) functions.extend((c[0], False) for c in cmdtable.values())
for func, rstrip in functions: for func, rstrip in functions:
if func.__doc__: if func.__doc__:
docobj = func # this might be a proxy to provide formatted doc docobj = func # this might be a proxy to provide formatted doc
func = getattr(func, '_origfunc', func) func = getattr(func, '_origfunc', func)
funcmod = inspect.getmodule(func) funcmod = inspect.getmodule(func)
extra = '' extra = ''
if funcmod.__package__ == funcmod.__name__: if funcmod.__package__ == funcmod.__name__: