This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9431

hghave: adjust the detection of `pylint` for modern versions
ClosedPublic

Authored by mharbison72 on Nov 27 2020, 5:12 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa9797b49fb69: hghave: adjust the detection of `pylint` for modern versions
Summary

I have pylint 2.6.0 installed locally, and it only has a single space. I have
no idea when this changed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Nov 27 2020, 5:12 PM
pulkit accepted this revision.Nov 28 2020, 4:32 AM
This revision is now accepted and ready to land.Nov 28 2020, 4:32 AM

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (2 lines)

Diff 23765

tests/hghave.py

except ImportError: except ImportError:
return False return False
else: else:
return True return True
@check("pylint", "Pylint python linter") @check("pylint", "Pylint python linter")
def has_pylint(): def has_pylint():
return matchoutput("pylint --help", br"Usage: pylint", True) return matchoutput("pylint --help", br"Usage:[ ]+pylint", True)
@check("clang-format", "clang-format C code formatter") @check("clang-format", "clang-format C code formatter")
def has_clang_format(): def has_clang_format():
m = matchoutput('clang-format --version', br'clang-format version (\d+)') m = matchoutput('clang-format --version', br'clang-format version (\d+)')
# style changed somewhere between 4.x and 6.x # style changed somewhere between 4.x and 6.x
return m and int(m.group(1)) >= 6 return m and int(m.group(1)) >= 6