This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9478

rhg: add a test for --rev with a hex changeset ID
ClosedPublic

Authored by SimonSapin on Dec 1 2020, 1:27 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG904647f7d983: rhg: add a test for --rev with a hex changeset ID
Summary

And fix error message formatting

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.Dec 1 2020, 1:27 PM
pulkit accepted this revision.Dec 2 2020, 2:12 AM
This revision is now accepted and ready to land.Dec 2 2020, 2:12 AM
SimonSapin added a commit: rHG904647f7d983: rhg: add a test for --rev with a hex changeset ID.Dec 2 2020, 3:04 AM
Closed by commit rHG904647f7d983: rhg: add a test for --rev with a hex changeset ID (authored by SimonSapin). · Explain Why
This revision was automatically updated to reflect the committed changes.
SimonSapin updated this revision to Diff 23935.Dec 2 2020, 9:22 AM

Revision Contents
Changeset List

Diff 23935

rust/rhg/src/commands/cat.rs

fn map_rev_error(rev: &str, err: CatRevError) -> CommandError { fn map_rev_error(rev: &str, err: CatRevError) -> CommandError {
CommandError { CommandError {
kind: match err.kind { kind: match err.kind {
CatRevErrorKind::IoError(err) => CommandErrorKind::Abort(Some( CatRevErrorKind::IoError(err) => CommandErrorKind::Abort(Some(
utf8_to_local(&format!("abort: {}\n", err)).into(), utf8_to_local(&format!("abort: {}\n", err)).into(),
)), )),
CatRevErrorKind::InvalidRevision => CommandErrorKind::Abort(Some( CatRevErrorKind::InvalidRevision => CommandErrorKind::Abort(Some(
utf8_to_local(&format!( utf8_to_local(&format!(
"abort: invalid revision identifier{}\n", "abort: invalid revision identifier {}\n",
rev rev
)) ))
.into(), .into(),
)), )),
CatRevErrorKind::UnsuportedRevlogVersion(version) => { CatRevErrorKind::UnsuportedRevlogVersion(version) => {
CommandErrorKind::Abort(Some( CommandErrorKind::Abort(Some(
utf8_to_local(&format!( utf8_to_local(&format!(
"abort: unsupported revlog version {}\n", "abort: unsupported revlog version {}\n",

rust/rhg/src/commands/files.rs

ListRevTrackedFilesErrorKind::IoError(err) => { ListRevTrackedFilesErrorKind::IoError(err) => {
CommandErrorKind::Abort(Some( CommandErrorKind::Abort(Some(
utf8_to_local(&format!("abort: {}\n", err)).into(), utf8_to_local(&format!("abort: {}\n", err)).into(),
)) ))
} }
ListRevTrackedFilesErrorKind::InvalidRevision => { ListRevTrackedFilesErrorKind::InvalidRevision => {
CommandErrorKind::Abort(Some( CommandErrorKind::Abort(Some(
utf8_to_local(&format!( utf8_to_local(&format!(
"abort: invalid revision identifier{}\n", "abort: invalid revision identifier {}\n",
rev rev
)) ))
.into(), .into(),
)) ))
} }
ListRevTrackedFilesErrorKind::UnsuportedRevlogVersion(version) => { ListRevTrackedFilesErrorKind::UnsuportedRevlogVersion(version) => {
CommandErrorKind::Abort(Some( CommandErrorKind::Abort(Some(
utf8_to_local(&format!( utf8_to_local(&format!(

tests/test-rhg.t

$ rhg cat -r 0 original $ rhg cat -r 0 original
original content original content
Cat copied file should not display copy metadata Cat copied file should not display copy metadata
$ hg copy original copy_of_original $ hg copy original copy_of_original
$ hg commit -m "add copy of original" $ hg commit -m "add copy of original"
$ rhg cat -r 1 copy_of_original $ rhg cat -r 1 copy_of_original
original content original content
Specifying revisions by changeset ID
$ hg log
changeset: 1:41263439dc17
tag: tip
user: test
date: Thu Jan 01 00:00:00 1970 +0000
summary: add copy of original
changeset: 0:1c9e69808da7
user: test
date: Thu Jan 01 00:00:00 1970 +0000
summary: add original
$ rhg files -r 41263439dc17
abort: invalid revision identifier 41263439dc17
[255]
$ rhg cat -r 41263439dc17 original
abort: invalid revision identifier 41263439dc17
[255]
Requirements Requirements
$ rhg debugrequirements $ rhg debugrequirements
dotencode dotencode
fncache fncache
generaldelta generaldelta
revlogv1 revlogv1
sparserevlog sparserevlog
store store