This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9532

transaction: windows workaround for missing line iteration support
ClosedPublic

Authored by joerg.sonnenberger on Dec 7 2020, 5:24 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG88de2639901b: transaction: windows workaround for missing line iteration support
Summary

The mixedfilemodewrapper doesn't support line iteration, so just read
the whole file in one go.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit accepted this revision.Dec 7 2020, 8:47 AM
pulkit added a subscriber: pulkit.

Ha, I remember hitting the exception related to mixedfilemodewrapper.

This revision is now accepted and ready to land.Dec 7 2020, 8:47 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/transaction.py (2 lines)

Diff 24091

mercurial/transaction.py

if file in self._newfiles: if file in self._newfiles:
return 0 return 0
return self._offsetmap.get(file) return self._offsetmap.get(file)
@active @active
def readjournal(self): def readjournal(self):
self._file.seek(0) self._file.seek(0)
entries = [] entries = []
for l in self._file: for l in self._file.readlines():
file, troffset = l.split(b'\0') file, troffset = l.split(b'\0')
entries.append((file, int(troffset))) entries.append((file, int(troffset)))
return entries return entries
@active @active
def replace(self, file, offset): def replace(self, file, offset):
""" """
replace can only replace already committed entries replace can only replace already committed entries