This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9637

bundle2: drop some outdated comment
ClosedPublic

Authored by marmoute on Dec 19 2020, 9:57 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc511fef30290: bundle2: drop some outdated comment
Summary

This commend trace back to a very early bundle2 changeset c7ceae0faf69. And the
code moved past this warning over 5 years ago.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 19 2020, 9:57 AM
pulkit accepted this revision.Dec 21 2020, 6:53 AM
This revision is now accepted and ready to land.Dec 21 2020, 6:53 AM
marmoute added a commit: rHGc511fef30290: bundle2: drop some outdated comment.Dec 21 2020, 1:35 PM
Closed by commit rHGc511fef30290: bundle2: drop some outdated comment (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundle2.py (6 lines)

Diff 24459

mercurial/bundle2.py

b'version', b'version',
b'nbchanges', b'nbchanges',
b'exp-sidedata', b'exp-sidedata',
b'treemanifest', b'treemanifest',
b'targetphase', b'targetphase',
), ),
) )
def handlechangegroup(op, inpart): def handlechangegroup(op, inpart):
"""apply a changegroup part on the repo """apply a changegroup part on the repo"""
This is a very early implementation that will massive rework before being
inflicted to any end-user.
"""
from . import localrepo from . import localrepo
tr = op.gettransaction() tr = op.gettransaction()
unpackerversion = inpart.params.get(b'version', b'01') unpackerversion = inpart.params.get(b'version', b'01')
# We should raise an appropriate exception here # We should raise an appropriate exception here
cg = changegroup.getunbundler(unpackerversion, inpart, None) cg = changegroup.getunbundler(unpackerversion, inpart, None)
# the source and url passed here are overwritten by the one contained in # the source and url passed here are overwritten by the one contained in
# the transaction.hookargs argument. So 'bundle2' is a placeholder # the transaction.hookargs argument. So 'bundle2' is a placeholder