This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9791

revlog: migrate from PyEval_CallObject to PyObject_Call
ClosedPublic

Authored by durin42 on Jan 15 2021, 12:57 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGabba2d365373: revlog: migrate from PyEval_CallObject to PyObject_Call
Summary

The former was deprecated in 3.9.0.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 15 2021, 12:57 PM
durin42 added a commit: rHGabba2d365373: revlog: migrate from PyEval_CallObject to PyObject_Call.Jan 15 2021, 1:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGabba2d365373: revlog: migrate from PyEval_CallObject to PyObject_Call (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (2 lines)

Diff 24905

mercurial/cext/revlog.c

PyObject *arglist, *result; PyObject *arglist, *result;
int isfiltered; int isfiltered;
arglist = Py_BuildValue("(n)", arg); arglist = Py_BuildValue("(n)", arg);
if (!arglist) { if (!arglist) {
return -1; return -1;
} }
result = PyEval_CallObject(filter, arglist); result = PyObject_Call(filter, arglist, NULL);
Py_DECREF(arglist); Py_DECREF(arglist);
if (!result) { if (!result) {
return -1; return -1;
} }
/* PyObject_IsTrue returns 1 if true, 0 if false, -1 if error, /* PyObject_IsTrue returns 1 if true, 0 if false, -1 if error,
* same as this function, so we can just return it directly.*/ * same as this function, so we can just return it directly.*/
isfiltered = PyObject_IsTrue(result); isfiltered = PyObject_IsTrue(result);