This is an archive of the discontinued Mercurial Phabricator instance.

Differential D984

remotefilelog: ignore EEXIST error of mkdir
ClosedPublic

Authored by quark on Oct 6 2017, 3:24 PM.
Tags
None
Subscribers
None

Details

Reviewers
mbthomas
Group Reviewers
Restricted Project
Commits
rFBHGX74b13c3eb8a9: remotefilelog: ignore EEXIST error of mkdir
Summary

This fixes a race-condition reported by Steaphan Greene.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Oct 6 2017, 3:24 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2017, 3:24 PM
quark retitled this revision from remotefilelog: ignore EEXIST error of makedir to remotefilelog: ignore EEXIST error of mkdir.Oct 6 2017, 3:36 PM
mbthomas accepted this revision.Oct 12 2017, 1:17 PM
This revision is now accepted and ready to land.Oct 12 2017, 1:17 PM
Closed by commit rFBHGX74b13c3eb8a9: remotefilelog: ignore EEXIST error of mkdir (authored by quark). · Explain WhyOct 13 2017, 2:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mremotefilelog/shallowutil.py (6 lines)

Diff 2663

remotefilelog/shallowutil.py

try: try:
missingdirs = [path] missingdirs = [path]
path = os.path.dirname(path) path = os.path.dirname(path)
while path and not os.path.exists(path): while path and not os.path.exists(path):
missingdirs.append(path) missingdirs.append(path)
path = os.path.dirname(path) path = os.path.dirname(path)
for path in reversed(missingdirs): for path in reversed(missingdirs):
try:
os.mkdir(path) os.mkdir(path)
except OSError as ex:
if ex.errno != errno.EEXIST:
raise
for path in missingdirs: for path in missingdirs:
setstickygroupdir(path, gid, ui.warn) setstickygroupdir(path, gid, ui.warn)
finally: finally:
os.umask(oldumask) os.umask(oldumask)
def trygetattr(obj, names): def trygetattr(obj, names):
"""try different attribute names, return the first matched attribute, """try different attribute names, return the first matched attribute,