This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9898

narrow: delete a stale TODO about not sending groups the client already has
ClosedPublic

Authored by martinvonz on Jan 28 2021, 1:18 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG29e3e46b0a22: narrow: delete a stale TODO about not sending groups the client already has
Summary

2c5835b4246b changed the changegroup generation to not send
treemanifests for directories the client had before widening. As that
commit mentions, we had already stopped before that commit to send the
changelog and filelogs for files the client already had.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 28 2021, 1:18 AM
pulkit accepted this revision.Jan 28 2021, 1:12 PM
This revision is now accepted and ready to land.Jan 28 2021, 1:12 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/bundle2.py (2 lines)

Diff 25365

mercurial/bundle2.py

returns bundle2 of the data required for extending returns bundle2 of the data required for extending
""" """
commonnodes = set() commonnodes = set()
cl = repo.changelog cl = repo.changelog
for r in repo.revs(b"::%ln", common): for r in repo.revs(b"::%ln", common):
commonnodes.add(cl.node(r)) commonnodes.add(cl.node(r))
if commonnodes: if commonnodes:
# XXX: we should only send the filelogs (and treemanifest). user
# already has the changelog and manifest
packer = changegroup.getbundler( packer = changegroup.getbundler(
cgversion, cgversion,
repo, repo,
oldmatcher=oldmatcher, oldmatcher=oldmatcher,
matcher=newmatcher, matcher=newmatcher,
fullnodes=commonnodes, fullnodes=commonnodes,
) )
cgdata = packer.generate( cgdata = packer.generate(