Upstream hg recently introduced new developer warning if files inside .hg are
modified without taking a lock. The usual fix is to add file in
localrepository._wlockfreeprefix list, but it doesn't work for "needrebuild"
fastpartialmatch file because it's stored inside .hg/store.
So to get rid of developer warning let's move needrebuild file to .hg/.
And since we are detecting that partial index needs to be rebuilt in revlog class,
I also had to wrap runcommand() and create needrebuild file there, because
runcommand() has vfs object, while revlog class doesn't.
Details
Details
- Reviewers
durham - Group Reviewers
Restricted Project - Commits
- rFBHGXe1eed1cbdad6: fastpartialmatch: fix devel.warn
Run tests
Diff Detail
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
There is a diff that fixes the same issue - https://phab.mercurial-scm.org/D89, but this version seems a bit simpler and doesn't cause tests to fail
Comment Actions
Not a huge fan of passing the value back up via a config option, but I guess it's fine for now.