This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9932

nodemap: make `_persist_nodemap` a public function
ClosedPublic

Authored by pulkit on Jan 31 2021, 2:35 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG83f037acf71a: nodemap: make `_persist_nodemap` a public function
Summary

I will like to have a utility function using which we can directly write out
nodemap for a repository without going through the recloning process. This
function seems like the one containing important pieces for that. Let's make it
public.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jan 31 2021, 2:35 PM
pulkit added a commit: rHG83f037acf71a: nodemap: make `_persist_nodemap` a public function.Feb 2 2021, 1:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG83f037acf71a: nodemap: make `_persist_nodemap` a public function (authored by pulkit). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25470

mercurial/revlogutils/nodemap.py

if revlog.nodemap_file is None: if revlog.nodemap_file is None:
return # we do not use persistent_nodemap on this revlog return # we do not use persistent_nodemap on this revlog
# we need to happen after the changelog finalization, in that use "cl-" # we need to happen after the changelog finalization, in that use "cl-"
callback_id = b"nm-revlog-persistent-nodemap-%s" % revlog.nodemap_file callback_id = b"nm-revlog-persistent-nodemap-%s" % revlog.nodemap_file
if tr.hasfinalize(callback_id): if tr.hasfinalize(callback_id):
return # no need to register again return # no need to register again
tr.addpending( tr.addpending(
callback_id, lambda tr: _persist_nodemap(tr, revlog, pending=True) callback_id, lambda tr: persist_nodemap(tr, revlog, pending=True)
) )
tr.addfinalize(callback_id, lambda tr: _persist_nodemap(tr, revlog)) tr.addfinalize(callback_id, lambda tr: persist_nodemap(tr, revlog))
class _NoTransaction(object): class _NoTransaction(object):
"""transaction like object to update the nodemap outside a transaction""" """transaction like object to update the nodemap outside a transaction"""
def __init__(self): def __init__(self):
self._postclose = {} self._postclose = {}
setup (eg, `debugupdatecache`). setup (eg, `debugupdatecache`).
""" """
if revlog._inline: if revlog._inline:
return # inlined revlog are too small for this to be relevant return # inlined revlog are too small for this to be relevant
if revlog.nodemap_file is None: if revlog.nodemap_file is None:
return # we do not use persistent_nodemap on this revlog return # we do not use persistent_nodemap on this revlog
notr = _NoTransaction() notr = _NoTransaction()
_persist_nodemap(notr, revlog) persist_nodemap(notr, revlog)
for k in sorted(notr._postclose): for k in sorted(notr._postclose):
notr._postclose[k](None) notr._postclose[k](None)
def _persist_nodemap(tr, revlog, pending=False): def persist_nodemap(tr, revlog, pending=False):
"""Write nodemap data on disk for a given revlog""" """Write nodemap data on disk for a given revlog"""
if getattr(revlog, 'filteredrevs', ()): if getattr(revlog, 'filteredrevs', ()):
raise error.ProgrammingError( raise error.ProgrammingError(
"cannot persist nodemap of a filtered changelog" "cannot persist nodemap of a filtered changelog"
) )
if revlog.nodemap_file is None: if revlog.nodemap_file is None:
msg = "calling persist nodemap on a revlog without the feature enableb" msg = "calling persist nodemap on a revlog without the feature enableb"
raise error.ProgrammingError(msg) raise error.ProgrammingError(msg)