This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9953

tests: add a comment in a test that will hopefully save someone some time
ClosedPublic

Authored by spectral on Feb 3 2021, 8:16 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG02d91167cfc3: tests: add a comment in a test that will hopefully save someone some time
rHG0fd0a940cde2: tests: add a comment in a test that will hopefully save someone some time
Summary

I spent at least an hour, probably closer to 1.5, trying to figure out what this
was complaining about. Hopefully anyone else in my position will see this note
and not waste the time.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mtests/test-check-module-imports.t (4 lines)

Diff 25479

tests/test-check-module-imports.t

#require test-repo #require test-repo
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ import_checker="$TESTDIR"/../contrib/import-checker.py $ import_checker="$TESTDIR"/../contrib/import-checker.py
$ cd "$TESTDIR"/.. $ cd "$TESTDIR"/..
There are a handful of cases here that require renaming a module so it There are a handful of cases here that require renaming a module so it
doesn't overlap with a stdlib module name. There are also some cycles doesn't overlap with a stdlib module name. There are also some cycles
here that we should still endeavor to fix, and some cycles will be here that we should still endeavor to fix, and some cycles will be
hidden by deduplication algorithm in the cycle detector, so fixing hidden by deduplication algorithm in the cycle detector, so fixing
these may expose other cycles. these may expose other cycles.
Known-bad files are excluded by -X as some of them would produce unstable Known-bad files are excluded by -X as some of them would produce unstable
outputs, which should be fixed later. outputs, which should be fixed later.
NOTE: the `hg locate` command here only works on files that are known to
Mercurial. If you add an import of a new file and haven't yet `hg add`ed it, you
will likely receive warnings about a direct import.
$ testrepohg locate 'set:**.py or grep(r"^#!.*?python")' \ $ testrepohg locate 'set:**.py or grep(r"^#!.*?python")' \
> 'tests/**.t' \ > 'tests/**.t' \
> -X hgweb.cgi \ > -X hgweb.cgi \
> -X setup.py \ > -X setup.py \
> -X contrib/automation/ \ > -X contrib/automation/ \
> -X contrib/debugshell.py \ > -X contrib/debugshell.py \
> -X contrib/hgweb.fcgi \ > -X contrib/hgweb.fcgi \
> -X contrib/packaging/hg-docker \ > -X contrib/packaging/hg-docker \