Page MenuHomePhabricator

Work around for issue6456, check content of symlinks because st_size may indicate the size of encrypted data.
Needs ReviewPublic

Authored by cschuhen on Sun, Feb 7, 6:15 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

cschuhen created this revision.Sun, Feb 7, 6:15 PM
Alphare added a subscriber: Alphare.Mon, Feb 8, 8:59 AM
Alphare added inline comments.
mercurial/dirstate.py
1283

Looking at the issue, it looks like Yuya is advising to fall back to the slow path only when the size of the link differs. Is that not sufficient? If it is, please add this check.
I don't expect real-life repositories to contain a ton of symlinks, but let's not make the dirstate slower than it currently is.
I'll keep that use case in mind for the current rewrite, thanks for the report.