Work around for issue6456, check content of symlinks because st_size may indicate the size of encrypted data.
Needs ReviewPublic
Actions

Authored by cschuhen on Sun, Feb 7, 6:15 PM.

Details

Reviewers

None

Group Reviewers

hg-reviewers

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Alphare added inline comments.

mercurial/dirstate.py
1283	Looking at the issue, it looks like Yuya is advising to fall back to the slow path only when the size of the link differs. Is that not sufficient? If it is, please add this check. I don't expect real-life repositories to contain a ton of symlinks, but let's not make the dirstate slower than it currently is. I'll keep that use case in mind for the current rewrite, thanks for the report.

			Path	Packages
M			mercurial/context.py (4 lines)
M			mercurial/dirstate.py (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25496			Sun, Feb 7, 6:15 PM	★	★